feat: skip deposit already created in the session#18
Merged
matteojug-stacks merged 2 commits intomainfrom Mar 30, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR reduces redundant calls to Emily by tracking deposits created during the current process run and skipping re-creation attempts for the same (txid, vout) pair. It also updates the default configuration and bumps the Rust toolchain version.
Changes:
- Track locally created deposits in
DepositMonitorvia an LRU cache and skip them when building pending deposit requests. - Record successful deposit creation events from the main runloop into the monitor.
- Update
default.tomllock time and bump the Rust toolchain version.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/main.rs |
Records successful deposit creation in the monitor to enable session-level deduping. |
src/deposit_monitor.rs |
Adds an LRU cache for created deposits and filters out already-created UTXOs from pending deposit generation. |
src/config/default.toml |
Updates default lock_time and clarifies reclaim script configuration guidance. |
rust-toolchain.toml |
Bumps Rust toolchain channel to a newer version. |
Cargo.toml |
Normalizes dependency formatting (no functional change). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
djordon-stacks
approved these changes
Mar 27, 2026
djordon-stacks
left a comment
There was a problem hiding this comment.
Largely looks good, just one small nit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep track of deposits created in the current run and skip creating them multiple times.
Also:
Testing Information
Tested locally with #17