Skip to content

feat: skip deposit already created in the session#18

Merged
matteojug-stacks merged 2 commits intomainfrom
feat/skip-already-created-deposits
Mar 30, 2026
Merged

feat: skip deposit already created in the session#18
matteojug-stacks merged 2 commits intomainfrom
feat/skip-already-created-deposits

Conversation

@matteojug-stacks
Copy link
Copy Markdown
Contributor

Keep track of deposits created in the current run and skip creating them multiple times.

Also:

  • bump rust to latest
  • update the "default" config

Testing Information

Tested locally with #17

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces redundant calls to Emily by tracking deposits created during the current process run and skipping re-creation attempts for the same (txid, vout) pair. It also updates the default configuration and bumps the Rust toolchain version.

Changes:

  • Track locally created deposits in DepositMonitor via an LRU cache and skip them when building pending deposit requests.
  • Record successful deposit creation events from the main runloop into the monitor.
  • Update default.toml lock time and bump the Rust toolchain version.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/main.rs Records successful deposit creation in the monitor to enable session-level deduping.
src/deposit_monitor.rs Adds an LRU cache for created deposits and filters out already-created UTXOs from pending deposit generation.
src/config/default.toml Updates default lock_time and clarifies reclaim script configuration guidance.
rust-toolchain.toml Bumps Rust toolchain channel to a newer version.
Cargo.toml Normalizes dependency formatting (no functional change).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

@djordon-stacks djordon-stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Largely looks good, just one small nit.

@matteojug-stacks matteojug-stacks added this pull request to the merge queue Mar 30, 2026
Merged via the queue into main with commit ddf2c30 Mar 30, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants