feat!: SharedKernel StudentIdの実装#87
Merged
Merged
Conversation
学籍番号の値オブジェクトを追加。旧形式（8桁数字）と新形式（3桁数字+英字+4桁数字）に対応し、 小文字英字の大文字正規化・前後空白トリムを行うファクトリメソッドを提供する。 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
OLD_FORMAT/NEW_FORMAT → NUMERIC_ONLY/ALPHANUMERIC に改名し、 2025年度からの形式変更をコメントに記載。 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Member集約およびユースケース・リポジトリでstring型だったstudentIdを StudentId値オブジェクトに置き換え、システム境界でバリデーションを保証する。 BREAKING CHANGE: Member constructor, setStudentId, getStudentIdの型がstringからStudentIdに変更 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
KinjiKawaguchi
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
KinjiKawaguchi
added a commit
that referenced
this pull request
Mar 23, 2026
## Summary - 学籍番号（StudentId）の値オブジェクトをSharedKernelとして追加 - 旧形式（8桁数字）と新形式（3桁数字+英字+4桁数字）の両方に対応 - `fromString` ファクトリメソッドで小文字→大文字正規化・空白トリムを実施 - private constructorにより直接インスタンス化を防止 - 12件のユニットテストを追加 ## Test plan - [x] 旧形式・新形式の正常系テスト - [x] 大文字正規化・空白トリムのテスト - [x] 桁数不正・英字のみ・英字位置不正・空文字等の異常系テスト - [x] equalsメソッドの等価性テスト - [x] lint, typecheck, test全てパス ## Related - PR #81 から StudentId 部分を分割したPR - マージ後、PR #81 をリベースしてAffiliation部分のみにする 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- devin-review-badge-begin --> --- <a href="https://app.devin.ai/review/su-its/core/pull/87" target="_blank"> <picture> <source media="(prefers-color-scheme: dark)" srcset="https://static.devin.ai/assets/gh-open-in-devin-review-dark.svg?v=1"> <img src="https://static.devin.ai/assets/gh-open-in-devin-review-light.svg?v=1" alt="Open with Devin"> </picture> </a> <!-- devin-review-badge-end --> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fromStringファクトリメソッドで小文字→大文字正規化・空白トリムを実施Test plan
Related
🤖 Generated with Claude Code