feat: add dark mode CSS variables for consistent theme styling (Fixes #1025)#1137
Closed
zeroknowledge0x wants to merge 1 commit into
Closed
feat: add dark mode CSS variables for consistent theme styling (Fixes #1025)#1137zeroknowledge0x wants to merge 1 commit into
zeroknowledge0x wants to merge 1 commit into
Conversation
…ublime247#1025) Add [data-theme='dark'] CSS variables to ensure all customized styling components render correctly in both light and dark modes. Changes: - Add dark mode primary color variables (brighter green for dark backgrounds) - Add dark mode Redoc copy button styling - Add dark mode sidebar, navbar, and footer styling - Follow Docusaurus convention using [data-theme='dark'] selector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1025
Summary
Add dark mode CSS variables to ensure all customized styling components render correctly in both light and dark themes.
Changes
docs-portal/src/css/custom.css:[data-theme='dark']block with primary color variables (brighter green for dark backgrounds)[data-theme='dark']selectorWhy This Works
Docusaurus uses
[data-theme='dark']attribute on the root element when dark mode is active. By defining CSS variables under this selector, all components that usevar(--ifm-color-primary)automatically adapt to the current theme.Color Choices
#2e8555(medium green) - already defined#4ecb71(brighter green) - better contrast on dark backgroundsTesting