Repository navigation
Conversation
Farhad-Shabani
approved these changes
Nov 19, 2026
| spn-network-types = { git = "https://github.com/succinctlabs/network", branch = "tobias/cap-artifact-download-size", features = ["network"] } | ||
| spn-pricing = { git = "https://github.com/succinctlabs/network", branch = "tobias/cap-artifact-download-size" } | ||
| spn-utils = { git = "https://github.com/succinctlabs/network", branch = "tobias/cap-artifact-download-size" } | ||
| spn-artifacts = { git = "https://github.com/succinctlabs/network", branch = "tobias/proto-stdin-too-large" } |
Collaborator
There was a problem hiding this comment.
Reminder to update to the 'main' branch before merging
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StdinandPrivateStdin.STDIN_TOO_LARGEin the failure payload, and the fulfiller passes that code to the network. The fulfiller also refuses to copy a stdin above the cap, and it fails the request with the same code.spn-*crates point at the branch of feat(proto): add STDIN_TOO_LARGE proof request error network#250. Both add the new error value.Motivation
The stdin is customer bytes, like the program. #214 gave the program a cap and left the stdin without one. A zstd bomb as stdin can use all the memory of a worker in the same way as a program bomb. The coordinator then requeues the tasks of the dead worker without a retry count.
Validation
cargo test: 234 passed, 0 failed, 19 ignored. Clippy with the CI flags,cargo fmt --checkandcargo deny checkpass.Caveats
spn-*crates must point atmainagain after feat(sdk): add StdinTooLarge proof request error sp1#3040 and feat(proto): add STDIN_TOO_LARGE proof request error network#250 merge. CI fails when those branches are deleted, so this cannot be missed.PROVING_FAILURE.