Repository navigation
fix: clippy 1.100 lint (needless_range_loop) - #3041
Merged
Merged
Conversation
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The WHIR prover loop iterates over
config.round_parameterswithenumerate(). It no longer indexes the list with a range variable.Motivation
The lint job uses stable Rust. Clippy from Rust 1.100 reports
needless_range_loopfor this loop, and the job fails on every new PR (for example #3040). The loop keeps the same order and the same number of rounds, becausen_roundsis the length ofconfig.round_parameters.Validation
cargo +1.100 clippy --all-features --all-targets -- -D warnings -A incomplete-featurespasses locally withSP1_CUDA_ENABLED=0, which matches the lint runner. Before the change, it failed with this one error.cargo +1.100 fmt --all -- --checkpasses.