Repository navigation
feat: add files, photos, and camera attachments to conversations - #26
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conversations now accept files, selected photos, or a new camera photo through the composer's + menu. Users can preview or remove attachments and send without text. Each message supports up to four attachments, with an 8 MiB limit per original/converted file; images are normalized to JPEG with a maximum edge of 2048 pixels.
Attachment bytes persist with the existing request ID/outbox and Pi transcript. Images use visual input; other files enter the conversation workspace for the read tool. Retry, explicit resend, reopened history, and checkpoint branches retain attachments. Retry does not overwrite files edited after the original submission. Picker cache copies are cleaned on capture or rejection, and late picker results cannot cross conversations.
This branch is based on current
mainand preserves its background execution leases, cancellation, activity display, and message menus. It includes only the attachment feature; unrelated changes in the original working checkout are excluded.Version metadata in the app, npm manifests, lockfile, and README is aligned to 0.8.0 for the minor release. The release/update regression suite passed all 24 tests.
Validation
npm run verify: passed — 262 tests passed, 37 optional native tests skipped; all 3 installer-script tests passed; strict types, portable smoke checks, and iOS/Android Hermes exports passed.npx expo-doctor: 20/20; Prettier and diff checks passed.Native dependencies require rebuilding the development client. Existing npm audit output contains 15 high-severity toolchain/transitive findings; no forced downgrade was applied. See attachment design and validation.