This repository was archived by the owner on Sep 29, 2022. It is now read-only.
🐛 Fix getting user#91
Open
alaninnovates wants to merge 1 commit into
Open
Conversation
acollierr17
suggested changes
Apr 3, 2022
Comment on lines
+29
to
+32
| let id; | ||
| const mention = userID.matchAll(MessageMentions.USERS_PATTERN).next().value; | ||
| if (!mention) id = userID; | ||
| else id = mention[1]; |
Member
There was a problem hiding this comment.
The code looks solid for starters. However, I think we can refactor this logic even more with the following:
const mention = userID.matchAll(MessageMentions.USERS_PATTERN).next().value;
const id = (mention && mention[1]) ?? userID;Let me know what you think!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle the cases: user id, mention in the
suggestionscommandFixes #81