♻️(api) remove bulk operations, rename documents to resources#133
Closed
StephanMeijer wants to merge 1 commit into
Closed
♻️(api) remove bulk operations, rename documents to resources#133StephanMeijer wants to merge 1 commit into
StephanMeijer wants to merge 1 commit into
Conversation
a0aacb8 to
cc9f4f1
Compare
ab4abbe to
d021f06
Compare
BREAKING CHANGE: API endpoints renamed and bulk operations removed. Signed-off-by: Stephan Meijer <me@stephanmeijer.com>
d021f06 to
19b46db
Compare
Collaborator
Author
|
Important This PR will be superseded by the next. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Please merge first: #131, #138
Summary
/documents/to/resources/POST /resources/index/accepts single doc only (returns 400 for arrays)DELETE /resources/<uuid>/(204/404/403)Breaking Changes
BREAKING CHANGE: API endpoints renamed and bulk operations removed.
POST /api/v1.0/documents/index/(bulk)POST /api/v1.0/resources/index/(single)POST /api/v1.0/documents/delete/(bulk)DELETE /api/v1.0/resources/<uuid>/POST /api/v1.0/documents/search/POST /api/v1.0/resources/search/Changes
core/urls.py: Renamed paths, added UUID path param for deletecore/views.py:IndexDocumentViewrejects arrays, newDeleteDocumentViewcore/schemas.py: RemovedDeleteDocumentsSchemademo/create_demo.py: Loop with single-doc API callscore/utils.py:prepare_index()acceptsserviceparam, uses APIClientTesting
All 30 new tests pass:
test_api_resources_index.py: 26 tests (single doc, validation, auth)test_api_resources_delete.py: 4 tests (success, 404, 403, invalid UUID)