Demo#139
Conversation
Signed-off-by: Stephan Meijer <me@stephanmeijer.com>
Signed-off-by: Stephan Meijer <me@stephanmeijer.com>
Signed-off-by: Stephan Meijer <me@stephanmeijer.com>
Signed-off-by: Stephan Meijer <me@stephanmeijer.com>
The VCR cassettes capture real OpenSearch HTTP interactions, eliminating the need to continuously update mocks when OpenSearch responses change. Signed-off-by: Stephan Meijer <me@stephanmeijer.com>
Signed-off-by: Stephan Meijer <me@stephanmeijer.com>
Signed-off-by: Stephan Meijer <me@stephanmeijer.com>
Signed-off-by: Stephan Meijer <me@stephanmeijer.com>
Signed-off-by: Stephan Meijer <me@stephanmeijer.com>
Signed-off-by: Stephan Meijer <me@stephanmeijer.com>
Signed-off-by: Stephan Meijer <me@stephanmeijer.com>
Signed-off-by: Stephan Meijer <me@stephanmeijer.com>
| uri: http://opensearch:9200/test-index | ||
| response: | ||
| body: | ||
| string: '{"error":{"root_cause":[{"type":"index_not_found_exception","reason":"no |
There was a problem hiding this comment.
Upserting indexes should not be part of the VCR. These are testing internals.
| @@ -0,0 +1,107 @@ | |||
| """Convert query DSL to OpenSearch queries.""" | |||
There was a problem hiding this comment.
@sampaccoud said in meeting he wants to reduce attack surface so in that light I will simplify the search.
| @@ -0,0 +1,107 @@ | |||
| """Convert query DSL to OpenSearch queries.""" | |||
There was a problem hiding this comment.
Search shall only be done by users, not individual apps (Docs, Fichier)
|
@StephanMeijer Closing this PR as I think it's too far from the way we work in this team and we would lose good decisions and important features that were carefully thought. Please start with a first PR importing the CONTRIBUTING.md from Docs https://github.com/suitenumerique/docs/blob/main/CONTRIBUTING.md Read it carefully especially the handbook and how we write tests in this team 🙏 I'm not saying its content does not contain great things but try opening PR of max 500 lines with a PR description with 2 chapters :
|
2 participants
Purpose
PR for the first demo given.