Skip to content

📦(helm) add support for specifying an existing secretName#154

Open
PascalCompiles wants to merge 1 commit into
suitenumerique:mainfrom
PascalCompiles:feat/helm-chart-improvement-allow-specifying-tls-secretName
Open

📦(helm) add support for specifying an existing secretName#154
PascalCompiles wants to merge 1 commit into
suitenumerique:mainfrom
PascalCompiles:feat/helm-chart-improvement-allow-specifying-tls-secretName

Conversation

@PascalCompiles
Copy link
Copy Markdown

Purpose

This pull request adds support for specifying a custom secretName within the Ingress configuration. This update makes the find chart consistent with how TLS secrets are handled across other La Suite numérique Helm charts.

  • Behavior Context: This configuration alignment follows the convention outlined in the docs helm chart README.md under ingress.tls.secretName.
  • Code Reference: The default/override logic is lifted directly from the docs helm chart here.

Proposal

  • Update templates/ingress.yaml to prioritize .Values.ingress.tls.secretName if provided, falling back to {{ $fullName }}-tls by default.
  • Add ingress.tls.secretName: null to values.yaml for clear user visibility.
  • Update the find helm chart README.md.
  • Bump helm chart version.

Signed-off-by: Pascal Noël <pascal@pascalcompiles.com>
@PascalCompiles PascalCompiles force-pushed the feat/helm-chart-improvement-allow-specifying-tls-secretName branch from d8597de to 4acc244 Compare May 26, 2026 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant