Skip to content

🐛(cal) fix display of recurring events with exceptions#686

Merged
sylvinus merged 1 commit into
mainfrom
ics_recurring_fix
May 29, 2026
Merged

🐛(cal) fix display of recurring events with exceptions#686
sylvinus merged 1 commit into
mainfrom
ics_recurring_fix

Conversation

@sylvinus
Copy link
Copy Markdown
Member

@sylvinus sylvinus commented May 29, 2026

Some events were being shown multiple times (one for each RRULE)

Summary by CodeRabbit

  • New Features
    • Recurring calendar invites now collapse into a single series entry per recurring event, eliminating duplicate cards for individual occurrences and providing a cleaner calendar view.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 6a192a83-de21-4fd4-a66d-015aaea7fad9

📥 Commits

Reviewing files that changed from the base of the PR and between 3f200ed and 15adb1c.

📒 Files selected for processing (3)
  • src/frontend/src/features/layouts/components/thread-view/components/calendar-invite/calendar-helper.tsx
  • src/frontend/src/features/layouts/components/thread-view/components/calendar-invite/index.test.ts
  • src/frontend/src/features/layouts/components/thread-view/components/calendar-invite/index.tsx

📝 Walkthrough

Walkthrough

This PR adds recurring calendar invite collapsing logic. A new utility groups VEVENTs by UID and selects one series representative per group (preferring master events), then integrates this into the calendar invite component to render one card per recurrence series instead of per occurrence.

Changes

Recurring calendar invite collapsing

Layer / File(s) Summary
Recurring event collapsing utilities
src/frontend/src/features/layouts/components/thread-view/components/calendar-invite/calendar-helper.tsx
pickSeriesRepresentative helper selects between two VEVENTs sharing a UID by preferring the master event (no recurrenceId), else the earlier start time. collapseRecurringEvents groups VEVENTs by uid (or per-index key for UID-less events), selects a representative per group, and returns one VEVENT per recurrence set in first-seen order.
Test coverage for recurring event collapsing
src/frontend/src/features/layouts/components/thread-view/components/calendar-invite/index.test.ts
Test suite validates master+override grouping into a single card, UID separation, stable first-seen ordering, UID-less event independence, earliest-occurrence selection when no master exists, and empty-input behavior.
Component integration of event collapsing
src/frontend/src/features/layouts/components/thread-view/components/calendar-invite/index.tsx
Calendar invite component imports and applies collapseRecurringEvents to transform parsed events before rendering, switching from one-card-per-occurrence to one-card-per-series representation.

🎯 2 (Simple) | ⏱️ ~12 minutes


Suggested reviewers

  • jbpenrath
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main objective: fixing the display of recurring calendar events with exceptions to prevent duplication.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sylvinus sylvinus merged commit d91e97d into main May 29, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant