♿️(frontend) fix menu semantics and trigger ARIA for screen readers#210
Open
Ovgodd wants to merge 1 commit into
Open
♿️(frontend) fix menu semantics and trigger ARIA for screen readers#210Ovgodd wants to merge 1 commit into
Ovgodd wants to merge 1 commit into
Conversation
Ovgodd
force-pushed
the
fix/a11y-dropdownmenu-menu-role-and-trigger-aria
branch
2 times, most recently
from
db32b34 to
b0eb7f8
Compare
Ovgodd
force-pushed
the
fix/a11y-dropdownmenu-menu-role-and-trigger-aria
branch
2 times, most recently
from
48c7ed7 to
b0df051
Compare
Dropdown menu exposes proper ARIA, Popover no longer announces as dialog
Ovgodd
force-pushed
the
fix/a11y-dropdownmenu-menu-role-and-trigger-aria
branch
from
b0df051 to
5a76b81
Compare
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Improve
DropdownMenuaccessibility semantics for screen readers:collapsed/expanded)dialogannouncement when opening a menu popupMain problem for the Dialog issue comes from React Aria
Proposal
aria-haspopup="menu",aria-expanded,aria-controls) on the actual interactive child, including when wrapped in layout elements.aria-labelledby/aria-controls).role="dialog"in menu usage, so SRs announce menu semantics instead of dialog semantics.