♿️(onboarding) improve OnboardingModal keyboard, screen reader, and preview content a11y#212
Open
Ovgodd wants to merge 2 commits into
Open
♿️(onboarding) improve OnboardingModal keyboard, screen reader, and preview content a11y#212Ovgodd wants to merge 2 commits into
Ovgodd wants to merge 2 commits into
Conversation
32801d7 to
8e16909
Compare
optional string to describe non-decorative preview media for screen readers.
manual activation, roving tabindex, panel ids, next/prev live region.
8e16909 to
fe2a51b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Improve OnboardingModal accessibility for keyboard and screen reader users:
contentAltwhen step preview media is not decorativeWhat stays on Cunningham: initial focus on the dialog title at open, and other
Modalchrome (dialog name, close button, etc.), tracked in Cunningham PR #390.Proposal
tabIndex={-1}); only step buttons use roving tabindex.contentAlton each step and expose it to assistive tech when preview content carries meaning.contentAltlinkage.