Improve chat message handling: use color for display, plain for detection (compatibility with chat plugins)#32
Open
OtakuSweett wants to merge 1 commit intosulphi-fox:masterfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to improve interoperability with other Bukkit/Spigot chat plugins by ensuring AsyncPlayerChatEvent#getMessage() is plain (no color codes) for detection/logging/moderation, while still displaying a colored version to players.
Changes:
- Strip color codes from the chat event message so downstream listeners see a plain message.
- Compute a colored version for player display and inject it into the chat output via
event.setFormat(...).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+135
to
+136
| coloredMessage = GeneralUtils.colourise(message); | ||
| } else { |
Comment on lines
+152
to
+153
| // Format: <name> colored_message | ||
| event.setFormat("<%1$s> " + coloredMessage); |
| } | ||
| } | ||
| // Format: <name> colored_message | ||
| event.setFormat("<%1$s> " + coloredMessage); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves chat message handling for better compatibility with other chat plugins, especially AxChatGames and similar.
Now, the message used for detection and processing by other plugins/listeners is plain (without color codes), while the message displayed to players keeps the color formatting.
This change ensures that chat games, moderation, logging, and other plugins see the raw message.