skills: MIT-derived engineering-process pack (decision-map, prototype, architecture-review) v4.7.0 - #83
Conversation
…type, architecture-review) v4.7.0 Port three gap-filling skills from mattpocock/skills @2ab95809 with adaptations: tracker feature-detection + write gate (decision-map), worktree isolation + production-safe gating (prototype), inlined deep-module vocabulary + self-contained report (architecture-review). Derived portions remain MIT; SPDX declares the three members MIT; provenance manifest at docs/third-party-skill-provenance.md; NOTICE and both README license boundaries updated with pinned expectations. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Rename process headings in the three new skills to the smoke test's accepted set (Workflow), and make the release-consistency test fixture consume check_release_consistency.NOTICE_TEXT instead of a duplicated literal so legal-text updates cannot drift the fixture again. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 603a30b76c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ated tracker precedes GitHub default Integrate the two live Codex review threads: the agent-collab SPDX package record now declares 'LicenseRef-PolyForm-Strict-1.0.0 AND MIT' (policy-only concluded likewise), and decision-map's tracker resolution puts a project-documented tracker ahead of the GitHub-remote default. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ea6e8f0841
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| 1. **Isolate the prototype from the caller's work.** Build it on an isolated | ||
| worktree or a clearly named throwaway branch. Never commit to, rebase, or | ||
| otherwise alter the branch the user was on without their explicit approval. |
There was a problem hiding this comment.
When this skill runs from a working tree with uncommitted changes, the permitted throwaway-branch option does not isolate the prototype: creating or switching branches retains those changes. This is especially dangerous for the preferred UI flow, which edits an existing page, because prototype edits can become inseparable from the caller's work or be staged with it. Require a separate worktree in this scenario, or stop for explicit approval to clean or stash the tree.
Useful? React with 👍 / 👎.
| 2. **GitHub Issues via the `gh` CLI** when the repo has a GitHub remote and no | ||
| documented tracker says otherwise. Feature-detect sub-issue and dependency | ||
| support (`gh issue create --parent`, `gh issue edit --blocked-by`) before | ||
| relying on it; on older CLI versions fall back to a `Blocked by: #N` body | ||
| convention and a task-list of child links in the map body. | ||
| 3. **Local markdown** when neither applies: the map at |
There was a problem hiding this comment.
For a repository with a GitHub remote but no installed or authenticated gh, this rule still selects GitHub solely from the remote, while the feature fallback only replaces unsupported relationship flags and still requires gh to create and edit issues. Because local markdown is reserved for when neither prior option applies, the skill has no executable path in this common environment; make CLI availability/authentication part of selection and fall back to local markdown when it fails.
Useful? React with 👍 / 👎.
…ompatible JSONL extension) v4.8.0 (#84) Deferred follow-up from #83. Spec materialization with precedence, ambiguity, no-synthesis, untrusted-data rules; Smell/Spec severities + optional spec_ref as a documented schema extension (skill version = contract version); spec/smell findings stay out of defect aggregation. Mixed-license member (PolyForm AND MIT) in SPDX; NOTICE generalized to point at the provenance document. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…omposition guidance v4.9.0 (#85) Second deferred follow-up from #83. Feature-implementation-only scope with named inapplicability; expand-contract reserved for genuine coexistence-required migrations (codemoddable changes run as checkpointed verified batches); bounded-worker-invocation sizing. Adapted portions attributed (to-tickets @2ab95809); both members mixed PolyForm AND MIT in SPDX. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
1 participant
Summary
Adds the engineering-process skill pack — three self-executed skills derived from the MIT-licensed mattpocock/skills repository at pinned commit
2ab958093e83e0ec752e6c1c5932da465bf23e0c, filling gaps the operator selected after a full gap analysis against the externally-maintained superpowers set and this package's routed-consultation skills:decision-map(from upstreamwayfinder): multi-session planning as a shared map of decision tickets on the issue tracker. Adaptations: tracker resolution withghfeature detection + local-markdown fallback (no setup-skill config dependency), an explicit user-approval write gate before any tracker mutation, host-neutral sub-skill references.prototype: throwaway logic/UI prototypes answering one design question. Adaptations: upstreamLOGIC.md/UI.mdinlined (generated skill dirs areSKILL.md-only), isolated worktree/branch, no auto-commit, production-safe gate on the entire UI-variant mechanism.architecture-review(from upstreamimprove-codebase-architecture+codebase-design): self-executed sweep for module-deepening opportunities with a visual report. Adaptations: deep-module vocabulary inlined, report is fully self-contained (inline CSS/SVG, no CDN), composes with the routedarchitectconsultation; description explicitly disambiguates fromarchitect/code-review.Licensing: derived portions remain MIT. Each generated
SKILL.mdcarries the full MIT permission notice;scripts/build_release_evidence.pydeclares the three membersMITin SPDX output (test updated);docs/third-party-skill-provenance.mdmaps every local file to its upstream path + blob SHA;NOTICE(root + plugin, byte-parity) and both README license boundaries name the exception;check_release_consistency.py+test_public_distribution_contract.pypinned expectations updated to the new legal text.Version 4.6.0 → 4.7.0 (minor, additive) across all seven bump surfaces; 50 skills regenerated; changelog fragment added.
Deferred by design (kick off after this merges, per operator direction): (1)
code-reviewspec-fidelity axis + Fowler smell baseline (needs deliberate output-contract design); (2) conditional tracer-bullet/expand-contract decomposition guidance fororchestrate/teamwork.Validation
python3 scripts/build_skills.py --check— clean (50 skills)python3 -m unittest discover -s tests— 658/658 OK at this headpython3 scripts/check_release_consistency.py— RESULT: OKpython3 scripts/build-changelog.py --dry-run— OKCross-check (verbatim)
Codex (
gpt-5.6-sol, efforthigh, directcodex execunder the operator's 2026-08-03 broker-bypass authorization; managed broker routes all returned typedprotocol_error— known undeployed-fixes state):All nine concerns integrated: exact-commit pinning (2ab95809); host-neutral phrasing with inline fallbacks; references inlined per the SKILL.md-only build contract; mutation gates (tracker write gate, worktree isolation, production-safe UI gating); no-CDN self-contained report; full MIT notice + SPDX MIT member classification + provenance manifest + README/NOTICE boundary; code-review change deferred pending output-contract design; tracer-bullet change deferred; execution gates (name approval obtained from operator, collision check clean, fresh worktree off origin/main, spec-edit-then-regenerate, trigger-collision review, archive/SBOM tests, release-consistency, changelog dry-run).
Full Codex output
VERDICT: PROCEED-WITH-MODIFICATIONS
The selection is sound.
wayfinder,prototype, and the architecture sweep fill real gaps. The skip list is justified. The architecture skill should use a distinct name such asarchitecture-sweepordeepen-codebaseto distinguish self-executed analysis from the existing routedarchitectconsultation.Pin an exact upstream commit, not "v1.2.0." Use the reviewed commit
2ab958093e83e0ec752e6c1c5932da465bf23e0cor re-pin immediately before implementation, and record per-file provenance.Remove hard dependencies on Claude-specific facilities ("Explore subagent", direct
superpowers:brainstorminginvocation) — express as host-native bounded read-only exploration, a small inline questioning fallback, explicit disclosure that Superpowers integration is optional.The reference-file design conflicts with the repository build contract (
skill-specs/*.mdauthoritative; generated dirs permit onlySKILL.md) — either inline the references or extend the build tooling.Do not port the mutation behavior near-verbatim: preview/approval gate for wayfinder tracker writes; isolated worktree and no auto-commit for prototype; production-safe gate around the entire prototype route/variant behavior; inline CSS/SVG or vendored assets for the architecture report (no CDN); feature-detect GitHub CLI sub-issue/dependency support.
The
code-reviewchange is not merely prompt enrichment unless its output contract is designed explicitly — defer or design deliberately.Licensing: preserve the complete MIT license text in every distributed package containing substantial copied or adapted text; mark each derived skill with upstream path plus pinned commit; clarify those portions remain MIT; revise the plugin README's license boundary; ensure the notice is in policy-only as well as activation archives; update release-evidence/SBOM generation; add a provenance manifest.
Defer the optional
orchestrate/teamworkchanges to a separate PR; tracer bullets are harmful as a universal rule — make them explicitly conditional if later added.Execution gates: operator name approval before creating specs; collision check; fresh worktree from origin/main; edit skill-specs then regenerate; trigger-collision tests; asset/reference integrity and archive-presence tests; archive/SBOM rehearsal; complete unit tests, freshness check, changelog dry-run, release-consistency check, README/version synchronization; workspace companion PR linked before release completion.
With those changes, this is a coherent selective fork rather than an identity-diluting import.
(Note: operator overrode the concern-1 rename suggestion, selecting
architecture-reviewwith description-level disambiguation.)Operator approvals on record (this session): selective-incorporation direction; broker bypass for consultation; skill names
decision-map,prototype,architecture-review; follow-up PRs to start post-merge.author: claude
author_model: claude-fable-5 (effort: default)
standing_directives: global skill-change workflow (routing table, branch, trigger verification, validation); #1 trigger-phrase verification (explicit + situational in all three descriptions); #3 release per version bump (v4.7.0 tag after merge); #4 plugin-sync N/A (this IS the plugin change); #5 README sync (plugin README updated in this PR:
README updated; workspace companion PR at release); #7 model+effort stated for all consultations; #8 delegation economy (no subagent fan-out — single-author port; cross-check delegated cross-family)tier: 2
cross_check: PROCEED-WITH-MODIFICATIONS (codex gpt-5.6-sol, effort high, direct codex exec under operator broker-bypass authorization 2026-08-03; raw verdict quoted in PR body; all 9 concerns integrated or explicitly deferred per operator direction)
post_condition: 658/658 unit tests OK; build_skills --check clean (50 skills); check_release_consistency RESULT OK; changelog dry-run OK; no coordinator/provider/routing/runtime surface touched
mcp_coverage_gap: none — self-executed prose skills only; gemini_mcp_path: retired / not applicable
contributor_rights: OPERATOR-CONFIRMED
operator_reserved: no
plugin_affected: this PR is the plugin change
readme_refresh_status: README updated (plugin repo); workspace README companion follows at release
🤖 Generated with Claude Code