fix: preserve multi-information groups - #3
Merged
Conversation
Michael-F-Bryan
marked this pull request as draft
August 12, 2026 05:15
Michael-F-Bryan
marked this pull request as ready for review
August 12, 2026 05:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PX4
Mmessages declare a complete typed value in each message, but the reader treated continuations as raw byte fragments of the first declaration. Zoda changeschar[N]between continued entries, sodataset.Readstopped at the first one.This decodes each value against its own declaration and preserves the protocol's ordered groups through
Reader.MultiInformationanddataset.File.MultiInformation. It also retains PX4's emptychar[0]separator values without weakening ordinary metadata or format validation.Against the captured Zoda log, the Go reader now reaches EOF with 99 datasets, 3,598 records, 46 multi-information groups, and 396 values. The dataset, record, group, and value counts match
pyulog; the captured log remains outside the repository.