Skip to content

p_switch: P_InitSwitchList omits DEH_String wrapper on texture names #127

Description

@sunsided

Context

P_InitSwitchList in room/src/doom/p_switch.rs loads the switch texture table.

C behavior

The C source wraps each switch texture name with DEH_String() before looking it up, allowing Dehacked patches to rename switch textures.

Rust behavior

The Rust port uses the raw texture names without DEH_String, so Dehacked patches cannot override switch texture names.

Location

room/src/doom/p_switch.rs — P_InitSwitchList

Flagged with // FIXME: in the source.

Suggested fix

Route each texture name through DEH_String (or the Rust equivalent) before the texture lookup.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-p_switchArea: p_switchbugSomething isn't workingkilo-auto-fixAuto-generated label by Kilokilo-triagedAuto-generated label by Kilo

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions