fix: R_FindPlane aborts on visplane pool exhaustion - #162
VedantMadane wants to merge 2 commits into
Conversation
- R_FindPlane calls i_error! on visplane pool exhaustion instead of returning null Fixes sunsided#117 Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 file)
Previous Review Summaries (2 snapshots, latest commit 6ea8c18)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 6ea8c18)Status: No Issues Found | Recommendation: Merge Previous WARNING on Files Reviewed (1 file)
Previous review (commit 15c8a44)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (1 file)
Reviewed by kimi-k2.6 · Input: 64.6K · Output: 9.9K · Cached: 499.7K |
6ea8c18 to
d4973c4
Compare
d4973c4 to
6ea8c18
Compare
|
Doc comment already updated in 6ea8c18 to state abort via |
|
Resolved 1 review thread that is addressed on current head:
|
|
Soft bump — no further code change. Doc on R_FindPlane already states it aborts via crate::i_error! when the visplane pool (128 entries) is exhausted (fixed in 6ea8c18). Kilo’s later review also marked the stale-null doc as resolved. Ready for merge. |
Summary
R_FindPlane aborts on visplane pool exhaustion
Changes
Fixes #117