Skip to content

fix: R_FindPlane aborts on visplane pool exhaustion - #162

Open
VedantMadane wants to merge 2 commits into
sunsided:mainfrom
VedantMadane:fix/issue-117
Open

VedantMadane wants to merge 2 commits into
sunsided:mainfrom
VedantMadane:fix/issue-117

Conversation

@VedantMadane

Copy link
Copy Markdown

Summary

R_FindPlane aborts on visplane pool exhaustion

Changes

  • R_FindPlane calls i_error! on visplane pool exhaustion instead of returning null

Fixes #117

- R_FindPlane calls i_error! on visplane pool exhaustion instead of returning null

Fixes sunsided#117

Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
@VedantMadane
VedantMadane requested a review from sunsided as a code owner August 24, 2026 21:34
@github-actions github-actions Bot added the area-r_plane Area: r_plane label Aug 24, 2026
Comment thread room/src/doom/r_plane.rs Outdated
@kilo-code-bot

kilo-code-bot Bot commented Aug 24, 2026 •

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 file)
  • room/src/doom/r_plane.rs
Previous Review Summaries (2 snapshots, latest commit 6ea8c18)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 6ea8c18)

Status: No Issues Found | Recommendation: Merge

Previous WARNING on room/src/doom/r_plane.rs line 550 (stale doc comment) has been resolved.

Files Reviewed (1 file)
  • room/src/doom/r_plane.rs

Previous review (commit 15c8a44)

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
room/src/doom/r_plane.rs 550 Stale doc comment — function no longer returns null on exhaustion
Files Reviewed (1 file)
  • room/src/doom/r_plane.rs — 1 issue

Fix these issues in Kilo Cloud


Reviewed by kimi-k2.6 · Input: 64.6K · Output: 9.9K · Cached: 499.7K

@VedantMadane

Copy link
Copy Markdown
Author

Doc comment already updated in 6ea8c18 to state abort via i_error! on visplane pool exhaustion (no null return). Leaving the thread for maintainers; no further code change needed.

@VedantMadane

Copy link
Copy Markdown
Author

Resolved 1 review thread that is addressed on current head:

  • R_FindPlane doc comment now states it aborts via i_error! when the visplane pool is exhausted (no longer claims null return)

@VedantMadane

Copy link
Copy Markdown
Author

Soft bump — no further code change.

Doc on R_FindPlane already states it aborts via crate::i_error! when the visplane pool (128 entries) is exhausted (fixed in 6ea8c18). Kilo’s later review also marked the stale-null doc as resolved. Ready for merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-r_plane Area: r_plane

Projects

None yet

Development

Successfully merging this pull request may close these issues.

r_plane: R_FindPlane returns null on pool exhaustion instead of calling I_Error

1 participant