Merge:'refactor/Collect_L'| 重构卡带选择器#274
Merged
Merged
Conversation
评审者指南（在小型 PR 中折叠显示）评审者指南对 Collect_* 流水线配置 JSON（Launcher、Navigation、TeleportRecall）进行重构，可能是为了支持新的或更简洁的 cartridge/selector 行为，同时保持现有流水线结构的一致性。 文件级变更
技巧和命令与 Sourcery 交互
自定义你的使用体验访问你的 控制面板 以：
获取帮助Original review guide in EnglishReviewer's guide (collapsed on small PRs)Reviewer's GuideRefactors the Collect_* pipeline configuration JSONs (Launcher, Navigation, TeleportRecall), likely to support a new or cleaned‑up cartridge/selector behavior while keeping existing pipeline structure aligned. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - 我已经审查了你的更改，一切看起来都很棒！
帮我变得更有用！请在每条评论上点 👍 或 👎，我会根据你的反馈来改进之后的评审。
Original comment in English
Hey - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
📝 Walkthrough概览本次 PR 重构流水线配置，将多个控制流决策从内联自定义补丁逻辑转换为锚点驱动路由和标签重置机制。特征开关节点的 next 分支格式化为多行数组；快速购物车 OCR 检查节点、包框架定位、分页导航和包处理流程采用统一锚点架构。 变更流水线锚点驱动路由重构
估计代码审查工作量🎯 4 (复杂) | ⏱️ ~45 分钟 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
assets/resource/base/pipeline/Collect_TeleportRecall.json (1)
561-576:⚠️ Potential issue | 🟠 Major | ⚡ Quick win不要把这个共享恢复节点限制成只命中 5 次。
Collect_NviMap_SpeciaEveMap1#_MiniMap_SubMenu不是一次性业务节点，而是Event_1/Event_3共用的子菜单恢复点。MAA 的max_hit一旦用尽，后续在next里会直接跳过这个节点；这样同一轮任务里只要后面再次弹出“小地图图标子菜单”，这条链就再也没有机会把它点掉，Collect_NviMap_SpeciaEveMap1#_MiniMap很容易退化成重复尝试的空转。除非你已经用日志证明单次任务绝不会超过 5 次，否则这里的上限过紧。(maafw.com)As per coding guidelines,
assets/resource/**/pipeline/**/*.json:检查 next 跳转，防止构成非预期的死循环（除非 doc 明确是轮询）。🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@assets/resource/base/pipeline/Collect_TeleportRecall.json` around lines 561 - 576, Collect_NviMap_SpeciaEveMap1#_MiniMap_SubMenu 不该被硬性限制为 max_hit:5，因为这是 Event_1/Event_3 共享的恢复子菜单节点，会在一次任务中被重复使用；把该节点的 max_hit 删除或改为无限/足够大的值（或使用框架支持的“unlimited”/0 表示不限制），并同时检查 Collect_NviMap_SpeciaEveMap1#_MiniMap 与该节点在 next 跳转中的关系，确保修改后不会引入意外的死循环（按规则审查所有指向该子菜单的 next 分支，必要时加入条件/计数器或明确的退出分支以防环路）。
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@assets/resource/base/pipeline/Collect_Launcher.json`:
- Around line 2659-2678: Collect_Pack_Click can loop indefinitely because its
next array includes itself and its recognition is only Collect_QuickCart_Menu;
add an exit limiter by adding a "max_hit" (e.g., 3–5) to Collect_Pack_Click and
define a fallback branch when the max is reached that does a
reposition/menu-reset instead of retrying the same anchor—for example, after
max_hit route to [JumpBack]Global_WaitingForLoading or a relocation node (e.g.,
Collect_QuickCart_Reposition or another menu-reset node) so the selector chain
can escape the self-loop and continue recovery.
---
Outside diff comments:
In `@assets/resource/base/pipeline/Collect_TeleportRecall.json`:
- Around line 561-576: Collect_NviMap_SpeciaEveMap1#_MiniMap_SubMenu 不该被硬性限制为
max_hit:5，因为这是 Event_1/Event_3 共享的恢复子菜单节点，会在一次任务中被重复使用；把该节点的 max_hit
删除或改为无限/足够大的值（或使用框架支持的“unlimited”/0 表示不限制），并同时检查
Collect_NviMap_SpeciaEveMap1#_MiniMap 与该节点在 next
跳转中的关系，确保修改后不会引入意外的死循环（按规则审查所有指向该子菜单的 next 分支，必要时加入条件/计数器或明确的退出分支以防环路）。
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b9906065-1cd9-4e74-b336-89713e3d4b67
📒 Files selected for processing (3)
assets/resource/base/pipeline/Collect_Launcher.jsonassets/resource/base/pipeline/Collect_Navigation.jsonassets/resource/base/pipeline/Collect_TeleportRecall.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Enhancements:
Original summary in English
Summary by Sourcery
Enhancements:
Summary by CodeRabbit
发行说明