Merge:'hotfix/patch0517'| 一些质量更新#285
Merged
Merged
Conversation
Contributor
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (13)
📝 WalkthroughWalkthroughThis PR standardizes recognition node identifiers across 13 pipeline configuration files by converting from Chinese full-width quote bracket format ( ChangesConfiguration Node Identifier Standardization and UI Text Updates
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
审阅者指南（在小型 PR 中折叠显示）审阅者指南此热修复更新了若干流水线 JSON 配置：重命名并重新连接全局加载界面识别项，调整「箱庭」界面中固定（pin）按钮的 ROI，同时对多份流水线与界面配置文件进行了额外的质量优化。 更新后的全局加载识别和 pin ROI 流程图flowchart TD
WaitLoop[Global_loading_wait_loop]
anyOf[any_of recognitions]
Rec01[Rec_「Global_WaitingForLoading>_01]
Rec02[Rec_「Global_WaitingForLoading>_02]
Rec03[Rec_「Global_WaitingForLoading>_03]
Rec04[Rec_「Global_WaitingForLoading>_04]
Rec05[Rec_「Global_WaitingForLoading>_05]
Rec06[Rec_「Global_WaitingForLoading>_06]
PinUIDetect[箱庭 pin_button ROI updated]
WaitLoop --> anyOf
anyOf --> Rec01
anyOf --> Rec02
anyOf --> Rec03
anyOf --> Rec04
anyOf --> Rec05
anyOf --> Rec06
WaitLoop --> PinUIDetect
文件级变更
提示与命令与 Sourcery 交互
自定义你的使用体验访问你的 控制面板 以：
获取帮助Original review guide in EnglishReviewer's guide (collapsed on small PRs)Reviewer's GuideThis hotfix updates several pipeline JSON configurations: it renames and rewires the global loading-screen recognition entries and adjusts the ROI for the pin button in the ‘箱庭’ UI, along with additional quality tweaks across multiple pipeline and interface config files. Flow diagram for updated global loading recognition and pin ROIflowchart TD
WaitLoop[Global_loading_wait_loop]
anyOf[any_of recognitions]
Rec01[Rec_「Global_WaitingForLoading>_01]
Rec02[Rec_「Global_WaitingForLoading>_02]
Rec03[Rec_「Global_WaitingForLoading>_03]
Rec04[Rec_「Global_WaitingForLoading>_04]
Rec05[Rec_「Global_WaitingForLoading>_05]
Rec06[Rec_「Global_WaitingForLoading>_06]
PinUIDetect[箱庭 pin_button ROI updated]
WaitLoop --> anyOf
anyOf --> Rec01
anyOf --> Rec02
anyOf --> Rec03
anyOf --> Rec04
anyOf --> Rec05
anyOf --> Rec06
WaitLoop --> PinUIDetect
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - 我留下了一些高层次的反馈：
- 将标识符从
Rec_「Global_WaitingForLoading」_*重命名为Rec_「Global_WaitingForLoading>_*时，用>替代了原来的右括号，看起来是无意为之；建议回退这次修改，或统一这些名称以符合现有命名规范，以避免破坏任何已有引用。 - 在将
any_of数组中的条目改为新的Rec_「Global_WaitingForLoading>_*名称之后，请再次确认所有外部引用（其他 JSON 或代码）也都已同步更新，以确保这些识别器在运行时依然可以被正确解析。 - ‘pin’ 按钮识别的 ROI 更新后变化很大；建议确认这个更大的区域不会引入误报，并且仍然能紧密包围目标 UI 元素。
给 AI 代理的提示
Please address the comments from this code review:
## Overall Comments
- The identifier rename from `Rec_「Global_WaitingForLoading」_*` to `Rec_「Global_WaitingForLoading>_*` introduces a `>` in place of the closing bracket, which looks unintentional; consider reverting or standardizing these names to match the existing naming convention to avoid breaking any references.
- After changing the `any_of` array entries to the new `Rec_「Global_WaitingForLoading>_*` names, double-check that all external references (other JSONs or code) were updated consistently so these recognizers are still resolvable at runtime.
- The updated ROI for the 'pin' button recognition is significantly different; it may be worth confirming that this broader region doesn’t introduce false positives and still tightly encloses the intended UI element.让我变得更有用！请在每条评论上点击 👍 或 👎，我会根据你的反馈持续改进代码审查质量。
Original comment in English
Hey - I've left some high level feedback:
- The identifier rename from
Rec_「Global_WaitingForLoading」_*toRec_「Global_WaitingForLoading>_*introduces a>in place of the closing bracket, which looks unintentional; consider reverting or standardizing these names to match the existing naming convention to avoid breaking any references. - After changing the
any_ofarray entries to the newRec_「Global_WaitingForLoading>_*names, double-check that all external references (other JSONs or code) were updated consistently so these recognizers are still resolvable at runtime. - The updated ROI for the 'pin' button recognition is significantly different; it may be worth confirming that this broader region doesn’t introduce false positives and still tightly encloses the intended UI element.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The identifier rename from `Rec_「Global_WaitingForLoading」_*` to `Rec_「Global_WaitingForLoading>_*` introduces a `>` in place of the closing bracket, which looks unintentional; consider reverting or standardizing these names to match the existing naming convention to avoid breaking any references.
- After changing the `any_of` array entries to the new `Rec_「Global_WaitingForLoading>_*` names, double-check that all external references (other JSONs or code) were updated consistently so these recognizers are still resolvable at runtime.
- The updated ROI for the 'pin' button recognition is significantly different; it may be worth confirming that this broader region doesn’t introduce false positives and still tightly encloses the intended UI element.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
assets/resource/base/pipeline/EventBattle.json (1)
30-31: ⚡ Quick win把识别节点名统一成完整的
<...>形式。这 4 处重命名现在落成的是
「...>，前导全角左引号还在，和同批节点标准化格式不一致。文件内引用虽然自洽，但后续按<节点名>规则做批量检索、替换或脚本校验时会漏掉这一组。♻️ 建议修改
- "Rec_「Event_Event_Main>_Ocr_01", - "Rec_「Event_Event_Main>_Ocr_02" + "Rec_<Event_Event_Main>_Ocr_01", + "Rec_<Event_Event_Main>_Ocr_02" - "Rec_「Event_Event_Main>_Ocr_01": { + "Rec_<Event_Event_Main>_Ocr_01": { - "Rec_「Event_Event_Main>_Ocr_02": { + "Rec_<Event_Event_Main>_Ocr_02": { - "Rec_「SeasonEvent_MamonoFollow_Practice>_Ocr_01", - "Rec_「SeasonEvent_MamonoFollow_Practice>_Ocr_02" + "Rec_<SeasonEvent_MamonoFollow_Practice>_Ocr_01", + "Rec_<SeasonEvent_MamonoFollow_Practice>_Ocr_02" - "Rec_「SeasonEvent_MamonoFollow_Practice>_Ocr_01": { + "Rec_<SeasonEvent_MamonoFollow_Practice>_Ocr_01": { - "Rec_「SeasonEvent_MamonoFollow_Practice>_Ocr_02": { + "Rec_<SeasonEvent_MamonoFollow_Practice>_Ocr_02": {Also applies to: 43-56, 714-715, 723-745
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@assets/resource/base/pipeline/EventBattle.json` around lines 30 - 31, Some node names use a leading fullwidth left quote and stray '>' (e.g. "Rec_「Event_Event_Main>_Ocr_01", "Rec_「Event_Event_Main>_Ocr_02") instead of the standardized "<...>" enclosure; replace the fullwidth '「' with '<' and ensure the node identifier is wrapped as "<...>" (e.g. "Rec_<Event_Event_Main>_Ocr_01") for all occurrences (examples: Rec_「Event_Event_Main>_Ocr_01, Rec_「Event_Event_Main>_Ocr_02) including the other ranges called out (lines corresponding to 43-56, 714-715, 723-745) so the names match the rest of the file and will be found by scripts that expect the <...> format.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@assets/interface.json`:
- Line 62: The description strings in assets/interface.json contain mismatched
bracket/quote patterns like `「哥布林遗迹>` and `「一键速抽>`; locate the affected JSON
values (e.g., the "description" property shown and the other entries at the
comment’s referenced locations) and correct the punctuation to be well-formed:
for quoted names use matching full-width quotes `「...」`, or if angle brackets
were intended, replace with escaped HTML `<...>`; ensure all occurrences
of `「...>` are replaced consistently and validate the JSON after edits.
In `@assets/resource/base/pipeline/Arbitrage.json`:
- Around line 2591-2592: 文件中存在混用节点名分隔符（使用了「...> 而非目标改造的 <...>
形式），请统一替换所有类似节点名：查找并将像
Rec_「Arbitrage_Sell_Item_SellMenu>_Ocr_01、Rec_「Arbitrage_Sell_Item_SellMenu>_Ocr_02、Sub_「Arbitrage_Cooking>_Clr
等带有「...> 的标识全部改为对应的 <...> 形式（例如
Rec_<Arbitrage_Sell_Item_SellMenu>_Ocr_01），确保批量替换时保持其余前缀/后缀不变并校验文件中所有重复出现的实例均已更新以免后续检索/重构漏掉。
In `@assets/resource/base/pipeline/Global.json`:
- Around line 412-417: Rename the misformatted resource keys that include the
full-width bracket prefix/suffix to the standardized form: replace all
occurrences of "Rec_「Global_WaitingForLoading>_01" ... "_06" (and the similar
entries at the other reported locations) with "Rec_Global_WaitingForLoading_01"
... "_06" so they follow the target pattern Rec_<Name>_NN; update each exact
string instance (e.g., Rec_「Global_WaitingForLoading>_01,
Rec_「Global_WaitingForLoading>_02, etc.) to remove the leading "「" and trailing
">" and use underscores only.
---
Nitpick comments:
In `@assets/resource/base/pipeline/EventBattle.json`:
- Around line 30-31: Some node names use a leading fullwidth left quote and
stray '>' (e.g. "Rec_「Event_Event_Main>_Ocr_01",
"Rec_「Event_Event_Main>_Ocr_02") instead of the standardized "<...>" enclosure;
replace the fullwidth '「' with '<' and ensure the node identifier is wrapped as
"<...>" (e.g. "Rec_<Event_Event_Main>_Ocr_01") for all occurrences (examples:
Rec_「Event_Event_Main>_Ocr_01, Rec_「Event_Event_Main>_Ocr_02) including the
other ranges called out (lines corresponding to 43-56, 714-715, 723-745) so the
names match the rest of the file and will be found by scripts that expect the
<...> format.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 62f366bb-e9ab-4ad5-b677-a105d4eebb24
📒 Files selected for processing (13)
assets/interface.jsonassets/resource/base/pipeline/Arbitrage.jsonassets/resource/base/pipeline/AutoBattle.jsonassets/resource/base/pipeline/Collect_TeleportRecall.jsonassets/resource/base/pipeline/Daily.jsonassets/resource/base/pipeline/Equip.jsonassets/resource/base/pipeline/EventBattle.jsonassets/resource/base/pipeline/GACHA.jsonassets/resource/base/pipeline/GACHA_ADV.jsonassets/resource/base/pipeline/Global.jsonassets/resource/base/pipeline/Pass.jsonassets/resource/base/pipeline/Setup.jsonassets/resource/base/pipeline/Weekly.json
| "圣石洞穴属性" | ||
| ], | ||
| "description": "消耗每日免费米饭与火把，依次扫荡冒险航线·狩猎场、圣石洞穴。<br><span style=\"background-color:rgba(255,160,0,0.2)\"><b>注意：</b>请确认目标狩猎场已通关，且冒险航线「哥布林遗迹」已完成。</span>" | ||
| "description": "消耗每日免费米饭与火把，依次扫荡冒险航线·狩猎场、圣石洞穴。<br><span style=\"background-color:rgba(255,160,0,0.2)\"><b>注意：</b>请确认目标狩猎场已通关，且冒险航线「哥布林遗迹>已完成。</span>" |
Contributor
There was a problem hiding this comment.
文案括号/引号样式未成对，建议统一修正为合法引用格式
这些行里出现了 「...> 的混合写法（如“「哥布林遗迹>”、“「一键速抽>”），属于明显的文案配对错误。建议统一为 「...」（若是引用名称），或改为 <...>（若是尖括号表达），避免用户误读。
建议修复示例（按“引用名称”风格统一）
- "description": "消耗每日免费米饭与火把，依次扫荡冒险航线·狩猎场、圣石洞穴。<br><span style=\"background-color:rgba(255,160,0,0.2)\"><b>注意：</b>请确认目标狩猎场已通关，且冒险航线「哥布林遗迹>已完成。</span>"
+ "description": "消耗每日免费米饭与火把，依次扫荡冒险航线·狩猎场、圣石洞穴。<br><span style=\"background-color:rgba(255,160,0,0.2)\"><b>注意：</b>请确认目标狩猎场已通关，且冒险航线「哥布林遗迹」已完成。</span>"
- "description": "「地图采集[完整]>的单卡带模式，满足日常任务所需即停止。"
+ "description": "「地图采集[完整]」的单卡带模式，满足日常任务所需即停止。"
- "description": "依次执行：<b>N稀有短剑打造</b> → <b>强化</b>与<b>分解</b> → <b>精炼</b>。<br>精炼仅以 SR 或 UR 稀有度装备为对象；首次运行无需提前锁定装备，非正常锁定的装备可能导致流程失败。<br><span style=\"background-color:rgba(255,160,0,0.2)\"><b>组合技：</b>同时启用「精炼等级上限过滤>与「精炼排序>，可构造低等级优先强化队列——当前首位装备超出等级限制后，自动推进到下一优先装备。</span>"
+ "description": "依次执行：<b>N稀有短剑打造</b> → <b>强化</b>与<b>分解</b> → <b>精炼</b>。<br>精炼仅以 SR 或 UR 稀有度装备为对象；首次运行无需提前锁定装备，非正常锁定的装备可能导致流程失败。<br><span style=\"background-color:rgba(255,160,0,0.2)\"><b>组合技：</b>同时启用「精炼等级上限过滤」与「精炼排序」，可构造低等级优先强化队列——当前首位装备超出等级限制后，自动推进到下一优先装备。</span>"
- "description": "<b>白嫖抽卡：</b>每日免费一次的<span style=\"background-color:Silver; color:Black; border-radius:3px; padding:0 3px;\">角色</span>、<span style=\"background-color:Silver; color:Black; border-radius:3px; padding:0 3px;\">专属装备</span>抽取。<br><br>关闭「一键速抽>后，可启用保底留存、90钻付费抽等高级功能。<br><br><span style=\"color:Crimson;font-size:14px\"><b>付费钻是危险功能</b><br>务必仔细确认，平时常闭。脚本协议不承担其使用责任！<br>打开此<span style=\"background-color:Silver; color:Black; border-radius:3px; padding:0 3px;\">总开关</span>，则是你知晓并自行承担相关风险的意思表示！</span><br><br><img src=\"resource/image/GUI/CHAGA_Doc.png\" width=\"150\" />"
+ "description": "<b>白嫖抽卡：</b>每日免费一次的<span style=\"background-color:Silver; color:Black; border-radius:3px; padding:0 3px;\">角色</span>、<span style=\"background-color:Silver; color:Black; border-radius:3px; padding:0 3px;\">专属装备</span>抽取。<br><br>关闭「一键速抽」后，可启用保底留存、90钻付费抽等高级功能。<br><br><span style=\"color:Crimson;font-size:14px\"><b>付费钻是危险功能</b><br>务必仔细确认，平时常闭。脚本协议不承担其使用责任！<br>打开此<span style=\"background-color:Silver; color:Black; border-radius:3px; padding:0 3px;\">总开关</span>，则是你知晓并自行承担相关风险的意思表示！</span><br><br><img src=\"resource/image/GUI/CHAGA_Doc.png\" width=\"150\" />"
- "description": "是否扫荡狩猎场。<br>关闭时跳过；若同时选了「优先双倍>但当日无双倍图，仍会补打狩猎场。"
+ "description": "是否扫荡狩猎场。<br>关闭时跳过；若同时选了「优先双倍」但当日无双倍图，仍会补打狩猎场。"
- "description": "仅对精炼等级低于阈值的装备执行精炼，等级达标的跳过。<br>配合「精炼排序>可实现按优先级逐步推进的强化队列。"
+ "description": "仅对精炼等级低于阈值的装备执行精炼，等级达标的跳过。<br>配合「精炼排序」可实现按优先级逐步推进的强化队列。"
- "description": "利用「所有免费抽抽乐>一键完成全部免费抽。<br>开：快捷但禁用保底留存与90钻付费抽。<br>关：启用高级抽卡流程，子项可见。"
+ "description": "利用「所有免费抽抽乐」一键完成全部免费抽。<br>开：快捷但禁用保底留存与90钻付费抽。<br>关：启用高级抽卡流程，子项可见。"
- "description": "关：默认流程检测到问题时自动启用。<br>开：从头调用高级抽卡流程，可配合「5星必出保留>使用。"
+ "description": "关：默认流程检测到问题时自动启用。<br>开：从头调用高级抽卡流程，可配合「5星必出保留」使用。"As per coding guidelines，assets/interface.json 需“文案合理清晰、括号与标点成对样式正确，尖括号使用 HTML 转义 <...>”。
Also applies to: 69-69, 80-80, 96-96, 352-352, 760-760, 856-856, 884-884
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@assets/interface.json` at line 62, The description strings in
assets/interface.json contain mismatched bracket/quote patterns like `「哥布林遗迹>`
and `「一键速抽>`; locate the affected JSON values (e.g., the "description" property
shown and the other entries at the comment’s referenced locations) and correct
the punctuation to be well-formed: for quoted names use matching full-width
quotes `「...」`, or if angle brackets were intended, replace with escaped HTML
`<...>`; ensure all occurrences of `「...>` are replaced consistently and
validate the JSON after edits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
调整全局加载界面识别器，并优化 UI 模板匹配配置。
改进内容：
Original summary in English
Summary by Sourcery
Adjust global loading-screen recognizers and refine UI template matching configuration.
Enhancements:
Summary by CodeRabbit
Release Notes