feat(destinations): add redis destination#454
Open
bnjjj wants to merge 5 commits intosupabase:mainfrom
Open
Conversation
Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
Contributor
|
Thanks a lot for your contribution. We are currently evaluating which destinations to accept because doing so will involve additional maintenance work for the team. Hope you understand! |
Contributor
Author
|
Of course ! That's why I didn't implement all the tests I could write ! I wanted to have feedback first. Keep me updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
What is the new behavior?
Add support of Redis as a destination. It could be pretty useful if you want to automatically replicate data for authentication like tokens in your redis storage to act as a cache and be updated automatically.
That's also one of the reason I added support with methods like
map_insert,map_updateorfilterto let users override and filter the value before inserting/updating it in Redis.Example:
Additional context
To make tests pass I added redis in docker-compose