fix: page advisor lint results - #324
Open
ahfoysal wants to merge 1 commit into
Open
Conversation
anp0429
pushed a commit
to anp0429/agentboard
that referenced
this pull request
Jul 22, 2026
…ml; abort on base-less worktree review that misses the target Three defects surfaced by one gating run on supabase/mcp#324: 1. Environment failures printed `stderr or stdout`: a harmless npm warning on stderr masked the real error on stdout (ERR_PNPM_RECURSIVE_EXEC_FIRST_FAIL). New _proc_tail() reports every non-empty stream, labeled. Applied to install/build/smoke paths in both verifiers. 2. supabase/mcp dropped packageManager and pins pnpm in mise.toml ([tools] pnpm = "10"); detect_pnpm_version fell back to 9, running the repo under a pnpm its workspace config was never written for. Detection now reads mise.toml and .tool-versions when package.json has no pin. packageManager still wins when present. 3. --worktree with no --base diffs the working tree against HEAD; on a clean PR checkout that is a near-empty diff, and the review ran anyway on intent alone (37 chars gated as if they were the PR). Now aborts with the fix named when the diff does not touch --target.
anp0429
pushed a commit
to anp0429/agentboard
that referenced
this pull request
Jul 22, 2026
…ct; existing tests are ground truth for setup and result shape Two lessons from gating supabase/mcp#324, one run apart: 1. Nine confirmed gaps in a single run all failed with the verbatim message 'Target cannot be null or undefined.' — every generated test unwrapped the tool response with the wrong shape. Real gaps fail in their own words; artifacts fail in unison. New deterministic pass (flag_systematic_artifacts): >= 3 confirmed gaps sharing a verbatim first-line failure get an artifact_note and a run-level SYSTEMATIC FAILURE banner. Statuses never change; no model in the loop. 2. The run before that, 12 tests broke on setup copied from stale harness_notes while the diff's own added test demonstrated the correct seeding one screen away. The reviewer prompt now names the priority: the existing tests file (and the diff's own tests above all) are authoritative for setup and result unwrapping; harness_notes are background, and when they conflict, the tests win.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds optional
limitandoffsetinputs toget_advisorsso large advisor responses can be fetched in smaller chunks.This keeps the existing behavior unchanged when pagination options are omitted, but when either option is provided the returned
lintsarray is sliced and a smallpaginationobject is included withtotal,offset,limit, andnext_offsetwhen another page exists.Fixes #124.
Validation
CI=1 ./node_modules/.bin/vitest run --project unit src/server.test.tsfrompackages/mcp-server-supabase./node_modules/.bin/tsc --noEmitfrompackages/mcp-server-supabase./node_modules/.bin/biome check packages/mcp-server-supabase/src/tools/debugging-tools.ts packages/mcp-server-supabase/src/server.test.ts packages/mcp-server-supabase/test/mocks.tsgit diff --check