Conversation
Describes the construction-time and per-request timeout contract for database.configuration.request_timeout: unit and default are documented per SDK, deadline or idle semantics both satisfy it, the bound applies per retry attempt, and it composes with caller-initiated cancellation. Co-Authored-By: Claude <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
specs/database/configuration/request_timeout.mdfordatabase.configuration.request_timeout, written alongside the Swift implementation in supabase/supabase-swift#1343.What the spec says
Durationin Swift). Each SDK documents its unit and any default it applies when nothing is set.Open question for CODEOWNERS
The capability description in
capabilities/database.yamlsays "in milliseconds" and "once the deadline is reached". This spec deliberately loosens both so that Swift'sURLRequest.timeoutInterval(seconds, idle) and postgrest-js'sAbortController(milliseconds, deadline) both qualify. If the team prefers deadline semantics as the contract, the Swift implementation needs awithTimeout(clock:)wrapper instead, and this spec should say so before more SDKs implement it.npm run validatepasses.Relates to SDK-1789.