ci(postgrest-typegen): drop the nightly parity job against postgres-meta - #192
Merged
spydon merged 1 commit intoSep 16, 2026
Merged
Conversation
postgres-meta deleted its own templates and consumes this package (supabase/postgres-meta#1084, postgres-meta v0.99.0), with its lockfile pinned to 0.2.0. The nightly "Parity vs. real postgres-meta" job was therefore diffing main against our own 0.2.0 release, and every intentional generator change since (Python fixes in 0.2.1, TypeScript collation in 0.2.2) failed it as "drift". There is no independent upstream left to compare against, so remove the job, its schedule and dispatch triggers, the three scripts that only served it, and rewrite the byte-parity docs to describe the post-cutover relationship.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
grdsdev
approved these changes
Sep 16, 2026
spydon
deleted the
lukasklingsbo/sdk-1847-remove-postgres-meta-parity-job
branch
September 16, 2026 08:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The scheduled "Parity vs. real postgres-meta" job in
postgrest-typegen-validate.ymlhas failed every night since 2026-09-10 (SDK-1847). The ticket assumed postgres-meta had changed its Python template after the cutover. It is the other way around: postgres-meta deleted its templates in supabase/postgres-meta#1084 (postgres-meta v0.99.0, 2026-08-31) and now consumes@supabase/postgrest-typegen, with its lockfile pinned to0.2.0.The job therefore diffs
mainagainst our own0.2.0release as installed by postgres-meta'snpm ci. Every intentional generator change since then shows up as "drift":JsonValue,typing_extensionsimports, andOptional[...]composite attributes (fix(postgrest-typegen): python escaping, 3.9 imports, JsonValue json columns, composite nullability #124, released in 0.2.1). In the diff, the-lines are postgres-meta's output and the+lines are ours.There is no independent upstream left to compare against. Comparing against postgres-meta only measures how far behind its pinned version is, and postgres-meta's own snapshot tests cover its adapter.
What
parity-checkjob and thescheduleandworkflow_dispatchtriggers that only existed for it; the remainingtestjob runs on push and pull requests as before.scripts/load-fixtures.ts,scripts/print-generated.ts, andscripts/canonicalize-typescript.ts, which only served that job, and drop their knip entries.CLAUDE.mdwith a description of the post-cutover relationship (this package is the single source of truth; output changes are behavior changes for postgres-meta and the CLI, reviewed via the regenerated snapshots and goldens). Adjust the README and the golden test's doc comment to match. Theprettierpin note was already stale since the package has no prettier dependency.The golden test under
test/parity/and itsexpected/files stay as the in-repo regression gate.Verification
bun run check-types,bun run format-and-lint,bun run knip, andbun run test(134 tests, including the testcontainers-backed golden test) pass locally.Closes SDK-1847.