Skip to content

ci(postgrest-typegen): drop the nightly parity job against postgres-meta - #192

Merged
spydon merged 1 commit into
mainfrom
lukasklingsbo/sdk-1847-remove-postgres-meta-parity-job
Sep 16, 2026
Merged

spydon merged 1 commit into
mainfrom
lukasklingsbo/sdk-1847-remove-postgres-meta-parity-job

Conversation

@spydon

@spydon spydon commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Why

The scheduled "Parity vs. real postgres-meta" job in postgrest-typegen-validate.yml has failed every night since 2026-09-10 (SDK-1847). The ticket assumed postgres-meta had changed its Python template after the cutover. It is the other way around: postgres-meta deleted its templates in supabase/postgres-meta#1084 (postgres-meta v0.99.0, 2026-08-31) and now consumes @supabase/postgrest-typegen, with its lockfile pinned to 0.2.0.

The job therefore diffs main against our own 0.2.0 release as installed by postgres-meta's npm ci. Every intentional generator change since then shows up as "drift":

There is no independent upstream left to compare against. Comparing against postgres-meta only measures how far behind its pinned version is, and postgres-meta's own snapshot tests cover its adapter.

What

  • Remove the parity-check job and the schedule and workflow_dispatch triggers that only existed for it; the remaining test job runs on push and pull requests as before.
  • Delete scripts/load-fixtures.ts, scripts/print-generated.ts, and scripts/canonicalize-typescript.ts, which only served that job, and drop their knip entries.
  • Replace the "Byte-Parity Constraint" section in the package CLAUDE.md with a description of the post-cutover relationship (this package is the single source of truth; output changes are behavior changes for postgres-meta and the CLI, reviewed via the regenerated snapshots and goldens). Adjust the README and the golden test's doc comment to match. The prettier pin note was already stale since the package has no prettier dependency.

The golden test under test/parity/ and its expected/ files stay as the in-repo regression gate.

Verification

bun run check-types, bun run format-and-lint, bun run knip, and bun run test (134 tests, including the testcontainers-backed golden test) pass locally.

Closes SDK-1847.

postgres-meta deleted its own templates and consumes this package
(supabase/postgres-meta#1084, postgres-meta v0.99.0), with its lockfile
pinned to 0.2.0. The nightly "Parity vs. real postgres-meta" job was
therefore diffing main against our own 0.2.0 release, and every
intentional generator change since (Python fixes in 0.2.1, TypeScript
collation in 0.2.2) failed it as "drift". There is no independent upstream
left to compare against, so remove the job, its schedule and dispatch
triggers, the three scripts that only served it, and rewrite the
byte-parity docs to describe the post-cutover relationship.
@spydon
spydon requested review from a team as code owners September 16, 2026 08:37
@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 5fb31e1e-6316-4d06-b2ab-217ac5c9c8e3


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@spydon
spydon merged commit 9eeaf0a into main Sep 16, 2026
4 checks passed
@spydon
spydon deleted the lukasklingsbo/sdk-1847-remove-postgres-meta-parity-job branch September 16, 2026 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants