fix(postgrest): build the typed transform builder with the row converter - #1850
Conversation
#1848 added stripNulls, dryRun, maxAffected and csv to the typed transform builder while #1849 replaced the builder's table field with a row converter. Both landed on main without seeing each other, so main does not compile: the four new methods still pass the removed `_table`, and two of their tests pass raw maps to the now typed insert and update.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe typed transform builder now forwards ChangesTyped transform builder
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to This is a localized typed-builder compilation fix with updated typed mutation tests and no identified behavioral or availability risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Main does not compile since #1848 and #1849 merged within minutes of each other. #1849 replaced the typed transform builder's
PostgrestTablefield with aRowConverter<Row>(_rowFromJson), and #1848 addedstripNulls,dryRun,maxAffectedandcsvon top of the old field. Neither PR's CI saw the other, so every check on main and on the open PRs fails at compile time inpostgrest_typed_transform_builder.dart:Changes
_rowFromJsonto the private constructor, like the rest of the class does after feat(postgrest)!: only accept the table's Insert and Update types on the typed builder #1849.BookInsertandBookUpdate, which feat(postgrest)!: only accept the table's Insert and Update types on the typed builder #1849 made the only accepted payload types on the typed builder.dryRundartdoc example usesBookInsertas well.No public API change.
dart analyzeonpackagesandexamplesis clean,typed_query_test.dartpasses (49), DCM is clean.Summary by CodeRabbit
Bug Fixes
Documentation