Conversation
Adopts the treatAllWarnings(as: .error) gate from pointfreeco/sqlite-data#467, activated only once the toolchain compiler is 6.4+. Stacked on feat/swift6-narrow-features.
Contributor
Author
|
Won't do for now — the pre-existing deprecation warnings in this repo would need to be resolved first, and this couldn't be validated against a real Swift 6.4 toolchain. Revisiting later if/when we bump CI to 6.4+. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
treatAllWarnings(as: .error)gate from pointfreeco/sqlite-data#467, active only when#if compiler(>=6.4).This repo currently has pre-existing deprecation warnings that this setting will turn into build failures once the CI toolchain moves to Swift 6.4+ (e.g.
defaultStorageEncoder/defaultStorageDecoderinStorage, deprecated APIs underSources/Realtime/Deprecated/). I could not test the gate actually engaging locally — this environment's toolchain is Swift 6.3.3, so the#if compiler(>=6.4)branch never activates and this PR is a no-op today.Before or alongside bumping CI to a 6.4+ toolchain, those pre-existing warnings should be resolved (or the affected targets excluded from this setting), otherwise the build will start failing with no code change once the compiler updates.
Test plan
swift buildsucceeds (gate inactive on this toolchain, so unchanged from PR1)