Skip to content

build: treat warnings as errors on compiler(>=6.4) - #1072

Closed
grdsdev wants to merge 1 commit into
feat/swift6-narrow-featuresfrom
feat/swift6-warnings-as-errors
Closed

grdsdev wants to merge 1 commit into
feat/swift6-narrow-featuresfrom
feat/swift6-warnings-as-errors

Conversation

@grdsdev

@grdsdev grdsdev commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

⚠️ Known risk — please read before merging

This repo currently has pre-existing deprecation warnings that this setting will turn into build failures once the CI toolchain moves to Swift 6.4+ (e.g. defaultStorageEncoder/defaultStorageDecoder in Storage, deprecated APIs under Sources/Realtime/Deprecated/). I could not test the gate actually engaging locally — this environment's toolchain is Swift 6.3.3, so the #if compiler(>=6.4) branch never activates and this PR is a no-op today.

Before or alongside bumping CI to a 6.4+ toolchain, those pre-existing warnings should be resolved (or the affected targets excluded from this setting), otherwise the build will start failing with no code change once the compiler updates.

Test plan

  • swift build succeeds (gate inactive on this toolchain, so unchanged from PR1)
  • Re-verify once CI/local toolchain reaches Swift 6.4, since the gate can't be exercised here

Adopts the treatAllWarnings(as: .error) gate from
pointfreeco/sqlite-data#467, activated only once the toolchain compiler
is 6.4+. Stacked on feat/swift6-narrow-features.
@grdsdev
grdsdev requested a review from a team as a code owner July 3, 2026 20:43
@grdsdev

grdsdev commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

Won't do for now — the pre-existing deprecation warnings in this repo would need to be resolved first, and this couldn't be validated against a real Swift 6.4 toolchain. Revisiting later if/when we bump CI to 6.4+.

@grdsdev grdsdev closed this Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant