shell-integration: route Supaterm SSH through the internal command - #7
Closed
khoi wants to merge 1 commit into
Closed
shell-integration: route Supaterm SSH through the internal command#7khoi wants to merge 1 commit into
khoi wants to merge 1 commit into
Conversation
khoi
force-pushed
the
fix/upstream-main-2026-08-08
branch
from
August 8, 2026 10:33
cf77774 to
e880644
Compare
khoi
force-pushed
the
fix/supaterm-internal-ssh-route
branch
from
August 8, 2026 10:34
5d8fa04 to
6cd138c
Compare
Author
|
Closing with the rejected public SSH scope. Shell integration will keep using the hidden |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The public
sp sshcommand now opens a tab. Shell-integratedsshmust keep exec semantics and must not create another tab recursively.What changed
The Bash, Zsh, Fish, Elvish, and Nushell wrappers now call
sp internal ssh --. The executable shell contract checks the exact route. Native+sshandcommand sshbehavior stay unchanged.Depends on
fix/upstream-main-2026-08-08.Verification
Related to SUP-132.