ci: enable supareview pull request reviews - #782
Conversation
SupaReviewFindingsThe workflow is syntactically valid and covers the intended non-draft lifecycle events, but it introduces a privileged mutable supply-chain dependency and invokes a secret/write-dependent workflow for PR sources that cannot receive those credentials or permissions. Findings
Review type: Full review Reviewers: thermo-nuclear-review-subagent, thermo-nuclear-code-quality-review-subagent |
|
Accepting both findings. I will pin the reusable workflow to reviewed commit |
Pin the reusable review workflow to a reviewed revision and skip pull requests that cannot provide the review secret or write token.
|
Changes since last review:
Commits: |
SupaReviewFindingsThe new condition correctly skips fork and Dependabot pull requests, and the caller reference is now a full SHA. However, that pinned reusable workflow still invokes a mutable @main action in the privileged, secret-bearing execution path, so the prior supply-chain risk remains incompletely fixed. Findings
Review type: Incremental review since a972792...8be9f05 Reviewers: thermo-nuclear-review-subagent, thermo-nuclear-code-quality-review-subagent |
|
Accepting the remaining finding. SupaReview PR #4 is merged as |
Use the merged SupaReview workflow revision that pins its nested privileged action.
|
Changes since last review:
Commit: |
SupaReviewLGTMThe only new change replaces the reusable-workflow reference with immutable SHA f1ed7e0d. That revision also pins the nested SupaReview action to immutable SHA 79badffe, resolving the remaining supply-chain concern. The existing fork and Dependabot guards remain intact, and no new issue is introduced by this delta. Review type: Incremental review since 8be9f05...79d169c Reviewers: thermo-nuclear-review-subagent, thermo-nuclear-code-quality-review-subagent |
Summary
Adds the SupaReview reusable workflow to Supacode. It reviews non-draft pull requests when they open, update, reopen, or leave draft state, with the required read and write permissions and the repository's
CODEX_BALANCER_API_KEYsecret.Type of change
ready)How was this tested?
The workflow matches the existing Supaterm SupaReview configuration. Local validation passed:
make checkpasses (format + lint)make testpassesmake build-appalso passed locally.AI tool disclosure (optional)
Checklist
Closes #above. Repository write-access exemption applies.ready.