Skip to content

test: verify terse review continuation - #3

Closed
khoi wants to merge 2 commits into
mainfrom
test/terse-continuation-prompt
Closed

test: verify terse review continuation#3
khoi wants to merge 2 commits into
mainfrom
test/terse-continuation-prompt

Conversation

@khoi

@khoi khoi commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

This temporary PR seeds a clear arithmetic bug, then fixes it in a second commit to verify that SupaReview restores the prior conversation and sends only the terse continuation prompt.

Note

This PR is only for end-to-end validation. It will not merge.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

SupaReview

Findings

The new helper has an off-by-one arithmetic error in its denominator, making its exported result incorrect for normal inputs. The issue is isolated to the added fixture and overlaps the reviewed diff.

Findings

  • [P2] Use the total attempt count as the denominator
    return successes / (attempts - 1);

    successRate subtracts one from the supplied attempt count, so it returns the wrong rate for every normal input (for example, successRate(5, 10) is 5/9 rather than 0.5). It also produces Infinity when there is one attempt instead of the expected 1. The denominator should be attempts itself.

Review type: Full review

Reviewers: thermo-nuclear-review-subagent, thermo-nuclear-code-quality-review-subagent

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

SupaReview

LGTM

The continuation patch fixes the prior off-by-one denominator by dividing by attempts and adds an explicit zero-attempt guard. Both review passes found no additional actionable issues in the incremental change.

Review type: Incremental review since 49fe5df...bcb8baa

Reviewers: thermo-nuclear-review-subagent, thermo-nuclear-code-quality-review-subagent

@khoi

khoi commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

End-to-end validation passed. The restored run received only the terse continuation prompt, derived the prior and current commits from conversation history and Git, reviewed the incremental diff, and confirmed the fix.

@khoi khoi closed this Aug 7, 2026
@khoi
khoi deleted the test/terse-continuation-prompt branch August 7, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant