mac: search command descriptions in the palette - #182
Conversation
SupaReviewLGTMBoth the bug/breakage audit and the code-quality audit found no qualifying issues. The patch consistently carries description-source matches through ranking and highlighting, preserves deterministic source ordering for ties, and updates the displayed subtitle only when a hidden description is actually matched (or when no subtitle exists). The changed call paths and focused tests align with that behavior. Review type: Full review Reviewers: thermo-nuclear-review-subagent, thermo-nuclear-code-quality-review-subagent |
🛠️ Tuist Run Report 🛠️Tests 🧪
Builds 🔨
|
Command description searchSearching
|
Descriptions were only tooltips, so commands could hide useful search context. Show the secondary field that produced each match and rank results by the weakest field touched while preserving source order within each tier.
d4d42ea to
41fde8d
Compare
Description search adds valid lower-ranked results for the initials query. Keep the UI check focused on filtering and the title match's first-place rank.
|
Changes since last review:
Commit: 5af410b |
1 participant
Why
Command descriptions were absent from palette search and display fallback. Mixed-field matches also needed stable ranking, and a description-only match could leave an unrelated subtitle visible.
What changed
Palette search now includes title, subtitle, and description. Results rank by the weakest field touched: title, then subtitle, then description, with source order preserved. When a match uses a hidden description, the row displays and highlights that description.
Verification
make mac-checkpassed