cli: open reconnecting SSH tabs - #184
Closed
khoi wants to merge 1 commit into
Closed
Conversation
The shell wrapper should preserve the current pane and recover dropped interactive sessions. Route public calls through tab creation while keeping direct system SSH launch internal for inherited sessions.
SupaReviewReview failed. |
Contributor
Author
|
Closing this scope. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The public
sp sshcommand only replaced the current process. It did not provide the tab-opening or reconnect flow requested for remote work.What changed
sp ssh <destination>now opens and focuses a normally placed tab.--namelocks its title. The hidden session runner retries only exit 255 with 2, 4, 8, 16, then capped 30-second waits. Other exits and Control-C stop retrying and return the tab to its local login shell.sp internal sshremains the exec shim for shell integration and inherited remote sessions. Help, user docs, developer docs, Ghostty routing, and bundled skill data now describe the split.Verification
make mac-check, docs check, validation, build, and dead-code scan passedDepends on
supabitapp/ghostty:fix/supaterm-internal-ssh-routeandsupabitapp/supaterm-skills:docs/ssh-tab-reconnect.Deliberately out of scope: ControlMaster policy, drag-and-drop uploads, and structured remote notifications.
Related to SUP-132.