mac: keep terminal chrome in sync with surface colors - #185
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
khoi
force-pushed
the
fix/ghostty-surface-config-parity
branch
from
August 8, 2026 12:17
599bbfc to
f46109e
Compare
SupaReviewOn it, AI code review will be updated here once ready. |
Terminal chrome, scrollbars, and progress used the app config after the terminal had derived a surface config. OSC 11 changes also stayed inside the renderer and left native chrome stale. Own the small derived config on each surface and keep its OSC background separate. A config refresh can then drop a stale OSC value while the selected pane drives native chrome.
khoi
force-pushed
the
fix/ghostty-security
branch
from
August 8, 2026 20:34
d5f4b79 to
1fe3e2d
Compare
khoi
force-pushed
the
fix/ghostty-surface-config-parity
branch
from
August 8, 2026 20:35
f46109e to
b79feb8
Compare
Surface config changes could leave replacement scroll wrappers stale, keep disabled progress visible in tab chrome, and drop configured opacity from the selected pane header. Resync wrapper ownership, filter progress at receipt, and carry opacity with the derived background.
🛠️ Tuist Run Report 🛠️Tests 🧪
Builds 🔨
|
khoi
force-pushed
the
fix/ghostty-surface-config-parity
branch
from
August 8, 2026 21:34
1e2d404 to
b3a489a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
OSC 11 could change the renderer background while Supaterm's top bar and chrome retained the global config color. Surface config callbacks also could not refresh target-specific scrollbar and progress state.
What changed
Each surface now owns derived background, opacity, scrollbar, and progress values. OSC background remains a separate override and clears when a later config background differs. The selected surface drives host chrome, including configured opacity. Scrollbars follow config background, not OSC 11, and resync when SwiftUI replaces their host view. Disabled progress reports no longer reach pane, sidebar, or tab state.
Foreground, cursor, and palette color actions remain consumed without changing native chrome.
Verification
make mac-checkmake mac-testmake mac-test-e2e(45 tests)make mac-scan-dead-codeFixes SUP-123.