Repository navigation
Report the real version in X-Search1API-Client, release 0.6.1 - #7
Merged
Merged
Conversation
The header has said python/0.3.0 since 0.3.0. The version now lives in search1api/_version.py and a test keeps it equal to pyproject.toml. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
X-Search1API-Clientrequest header has always saidpython/0.3.0, whatever version was installed. It now sendspython/<package version>.__version__moved tosearch1api/_version.py, soclient.pycan import it without importing the package__init__in a cycle.search1api.__version__is still exported.__version__equals the version inpyproject.tomland that the header uses it, so a version bump that forgets this file fails CI.How it was tested
On Python 3.9 and 3.12:
ruff format --check .: passed.ruff check .: passed.mypy src/search1api: passed.pytest: 25 passed, including 2 new tests.python -m buildproducessearch1api-0.6.1sdist and wheel.After release
python/0.6.1for this client.🤖 Generated with Claude Code