Skip to content

fix: make plugin release tarball paths npm 12 compatible #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
superche merged 1 commit into from
Jul 28, 2026
Merged

fix: make plugin release tarball paths npm 12 compatible #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/plugin-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
CONTRACTS_VERSION: ${{ steps.package-versions.outputs.contracts }}
run: |
set -euo pipefail
local_tarball="release/pippit-bridge-contracts-${CONTRACTS_VERSION}.tgz"
local_tarball="./release/pippit-bridge-contracts-${CONTRACTS_VERSION}.tgz"
package_spec="@pippit-bridge/contracts@${CONTRACTS_VERSION}"
if npm view "$package_spec" version --registry=https://registry.npmjs.org >/dev/null 2>&1; then
mkdir registry-contracts local-contracts registry-contracts-extracted
Expand Down Expand Up @@ -80,15 +80,15 @@ jobs:
tar -xzf "release/pippit-bridge-contracts-${CONTRACTS_VERSION}.tgz" -C local-contracts-verify
tar -xzf "registry-contracts-verify/pippit-bridge-contracts-${CONTRACTS_VERSION}.tgz" -C registry-contracts-extracted-verify
diff -ru local-contracts-verify/package registry-contracts-extracted-verify/package
npm install --prefix /tmp/pippit-contracts-registry-install --ignore-scripts "registry-contracts-verify/pippit-bridge-contracts-${CONTRACTS_VERSION}.tgz"
npm install --prefix /tmp/pippit-contracts-registry-install --ignore-scripts "./registry-contracts-verify/pippit-bridge-contracts-${CONTRACTS_VERSION}.tgz"
cd /tmp/pippit-contracts-registry-install
node --input-type=module --eval 'const contracts = await import("@pippit-bridge/contracts"); contracts.credentialIdContract.parse("123e4567-e89b-42d3-a456-426614174000")'
- name: Publish or verify the exact core dependency
env:
CORE_VERSION: ${{ steps.package-versions.outputs.core }}
run: |
set -euo pipefail
local_tarball="release/pippit-bridge-core-${CORE_VERSION}.tgz"
local_tarball="./release/pippit-bridge-core-${CORE_VERSION}.tgz"
package_spec="@pippit-bridge/core@${CORE_VERSION}"
if npm view "$package_spec" version --registry=https://registry.npmjs.org >/dev/null 2>&1; then
mkdir registry-core local-core registry-core-extracted
Expand Down Expand Up @@ -118,11 +118,11 @@ jobs:
tar -xzf "release/pippit-bridge-core-${CORE_VERSION}.tgz" -C local-core-verify
tar -xzf "registry-core-verify/pippit-bridge-core-${CORE_VERSION}.tgz" -C registry-core-extracted-verify
diff -ru local-core-verify/package registry-core-extracted-verify/package
npm install --prefix /tmp/pippit-core-registry-install --ignore-scripts "registry-core-verify/pippit-bridge-core-${CORE_VERSION}.tgz"
npm install --prefix /tmp/pippit-core-registry-install --ignore-scripts "./registry-core-verify/pippit-bridge-core-${CORE_VERSION}.tgz"
cd /tmp/pippit-core-registry-install
node --input-type=module --eval 'const core = await import("@pippit-bridge/core"); if (typeof core.readPrivateFile !== "function") throw new Error("CORE_PRIVATE_FILE_EXPORT_MISSING")'
- run: npm pack -w @pippit-bridge/mcp-server --pack-destination release
- run: npm publish "release/pippit-bridge-mcp-server-${{ inputs.version }}.tgz" --access public --provenance --registry=https://registry.npmjs.org
- run: npm publish "./release/pippit-bridge-mcp-server-${{ inputs.version }}.tgz" --access public --provenance --registry=https://registry.npmjs.org
- run: npm view "@pippit-bridge/mcp-server@${{ inputs.version }}" version dist.integrity dist.tarball --json --registry=https://registry.npmjs.org
- run: mkdir registry-verify && npm pack "@pippit-bridge/mcp-server@${{ inputs.version }}" --pack-destination registry-verify --registry=https://registry.npmjs.org
- name: Compare the registry MCP artifact with the published candidate
Expand All @@ -131,7 +131,7 @@ jobs:
tar -xzf "release/pippit-bridge-mcp-server-${{ inputs.version }}.tgz" -C local-mcp-verify
tar -xzf "registry-verify/pippit-bridge-mcp-server-${{ inputs.version }}.tgz" -C registry-mcp-extracted-verify
diff -ru local-mcp-verify/package registry-mcp-extracted-verify/package
- run: npm install --prefix /tmp/pippit-registry-install --ignore-scripts "registry-verify/pippit-bridge-mcp-server-${{ inputs.version }}.tgz"
- run: npm install --prefix /tmp/pippit-registry-install --ignore-scripts "./registry-verify/pippit-bridge-mcp-server-${{ inputs.version }}.tgz"
- run: node packages/mcp-server-pippit/scripts/smoke-installed-bin.mjs /tmp/pippit-registry-install/node_modules/.bin/pippit-mcp
- if: ${{ inputs.activate_marketplace }}
run: node scripts/activate-marketplace.mjs "${{ inputs.version }}"
Expand Down
19 changes: 18 additions & 1 deletion scripts/plugin-release-workflow.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ describe("plugin release dependency order", () => {
const corePublish = workflow.indexOf("name: Publish or verify the exact core dependency")
const coreInstall = workflow.indexOf("/tmp/pippit-core-registry-install")
const mcpPack = workflow.indexOf("npm pack -w @pippit-bridge/mcp-server")
const mcpPublish = workflow.indexOf("npm publish \"release/pippit-bridge-mcp-server-")
const mcpPublish = workflow.indexOf("npm publish \"./release/pippit-bridge-mcp-server-")

expect(contractsPack).toBeGreaterThan(-1)
expect(contractsPublish).toBeGreaterThan(contractsPack)
Expand All @@ -33,6 +33,23 @@ describe("plugin release dependency order", () => {
expect(workflow).toContain("smoke-installed-bin.mjs /tmp/pippit-registry-install/node_modules/.bin/pippit-mcp")
})

it("uses explicit relative tarball paths for npm 12 publish and install commands", async () => {
const workflow = await readFile(resolve(root, ".github/workflows/plugin-release.yml"), "utf8")

expect(workflow).toContain('local_tarball="./release/pippit-bridge-contracts-${CONTRACTS_VERSION}.tgz"')
expect(workflow).toContain('local_tarball="./release/pippit-bridge-core-${CORE_VERSION}.tgz"')
expect(workflow).toContain('npm publish "./release/pippit-bridge-mcp-server-${{ inputs.version }}.tgz"')
expect(workflow).toContain(
'npm install --prefix /tmp/pippit-contracts-registry-install --ignore-scripts "./registry-contracts-verify/pippit-bridge-contracts-${CONTRACTS_VERSION}.tgz"',
)
expect(workflow).toContain(
'npm install --prefix /tmp/pippit-core-registry-install --ignore-scripts "./registry-core-verify/pippit-bridge-core-${CORE_VERSION}.tgz"',
)
expect(workflow).toContain(
'npm install --prefix /tmp/pippit-registry-install --ignore-scripts "./registry-verify/pippit-bridge-mcp-server-${{ inputs.version }}.tgz"',
)
})

it("builds the contracts package from a clean checkout before packing", async () => {
const manifest = JSON.parse(await readFile(resolve(root, "packages/contracts/package.json"), "utf8")) as {
scripts?: Record<string, string>
Expand Down