Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 28 additions & 6 deletions .github/workflows/plugin-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
workflow_dispatch:
inputs:
version:
description: Exact unoccupied npm version
description: Exact npm version to publish or verify
required: true
activate_marketplace:
description: Open marketplace activation PR after registry verification
Expand Down Expand Up @@ -35,8 +35,6 @@ jobs:
run: |
echo "contracts=$(node -p "require('./packages/contracts/package.json').version")" >> "$GITHUB_OUTPUT"
echo "core=$(node -p "require('./packages/core/package.json').version")" >> "$GITHUB_OUTPUT"
- name: Refuse an occupied npm version
run: if npm view "@pippit-bridge/mcp-server@${{ inputs.version }}" version --registry=https://registry.npmjs.org; then exit 1; fi
- run: npm run check:public-lockfile
- run: npm ci
- run: npm run check:plugin-version && npm run check:plugin-contract && npm run check && npm run check:release-artifact && npm run check:dev-gateway
Expand Down Expand Up @@ -122,9 +120,33 @@ jobs:
cd /tmp/pippit-core-registry-install
node --input-type=module --eval 'const core = await import("@pippit-bridge/core"); if (typeof core.readPrivateFile !== "function") throw new Error("CORE_PRIVATE_FILE_EXPORT_MISSING")'
- run: npm pack -w @pippit-bridge/mcp-server --pack-destination release
- run: npm publish "./release/pippit-bridge-mcp-server-${{ inputs.version }}.tgz" --access public --provenance --registry=https://registry.npmjs.org
- run: npm view "@pippit-bridge/mcp-server@${{ inputs.version }}" version dist.integrity dist.tarball --json --registry=https://registry.npmjs.org
- run: mkdir registry-verify && npm pack "@pippit-bridge/mcp-server@${{ inputs.version }}" --pack-destination registry-verify --registry=https://registry.npmjs.org
- name: Publish or verify the exact MCP artifact
run: |
set -euo pipefail
local_tarball="./release/pippit-bridge-mcp-server-${{ inputs.version }}.tgz"
package_spec="@pippit-bridge/mcp-server@${{ inputs.version }}"
if npm view "$package_spec" version --registry=https://registry.npmjs.org >/dev/null 2>&1; then
mkdir registry-mcp-existing local-mcp-existing registry-mcp-existing-extracted
npm pack "$package_spec" --pack-destination registry-mcp-existing --registry=https://registry.npmjs.org
tar -xzf "$local_tarball" -C local-mcp-existing
tar -xzf "registry-mcp-existing/pippit-bridge-mcp-server-${{ inputs.version }}.tgz" -C registry-mcp-existing-extracted
diff -ru local-mcp-existing/package registry-mcp-existing-extracted/package
else
npm publish "$local_tarball" --access public --provenance --registry=https://registry.npmjs.org
fi
- name: Re-download the MCP artifact from the official registry
run: |
set -euo pipefail
package_spec="@pippit-bridge/mcp-server@${{ inputs.version }}"
for attempt in 1 2 3 4 5 6; do
if npm view "$package_spec" version dist.integrity dist.tarball --json --registry=https://registry.npmjs.org; then
break
fi
if [ "$attempt" = 6 ]; then exit 1; fi
sleep 10
done
mkdir registry-verify
npm pack "$package_spec" --pack-destination registry-verify --registry=https://registry.npmjs.org
- name: Compare the registry MCP artifact with the published candidate
run: |
mkdir local-mcp-verify registry-mcp-extracted-verify
Expand Down
16 changes: 14 additions & 2 deletions scripts/plugin-release-workflow.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ describe("plugin release dependency order", () => {
const corePublish = workflow.indexOf("name: Publish or verify the exact core dependency")
const coreInstall = workflow.indexOf("/tmp/pippit-core-registry-install")
const mcpPack = workflow.indexOf("npm pack -w @pippit-bridge/mcp-server")
const mcpPublish = workflow.indexOf("npm publish \"./release/pippit-bridge-mcp-server-")
const mcpPublish = workflow.indexOf("name: Publish or verify the exact MCP artifact")
const mcpInstall = workflow.indexOf("/tmp/pippit-registry-install")

expect(contractsPack).toBeGreaterThan(-1)
expect(contractsPublish).toBeGreaterThan(contractsPack)
Expand All @@ -24,21 +25,32 @@ describe("plugin release dependency order", () => {
expect(coreInstall).toBeGreaterThan(corePublish)
expect(mcpPack).toBeGreaterThan(coreInstall)
expect(mcpPublish).toBeGreaterThan(mcpPack)
expect(mcpInstall).toBeGreaterThan(mcpPublish)
expect(workflow).toContain("diff -ru local-contracts/package registry-contracts-extracted/package")
expect(workflow).toContain("diff -ru local-core/package registry-core-extracted/package")
expect(workflow).toContain("diff -ru local-contracts-verify/package registry-contracts-extracted-verify/package")
expect(workflow).toContain("diff -ru local-core-verify/package registry-core-extracted-verify/package")
expect(workflow).toContain("diff -ru local-mcp-verify/package registry-mcp-extracted-verify/package")
expect(workflow).toContain("npm run check:release-artifact && npm run check:dev-gateway")
expect(workflow).toContain("smoke-installed-bin.mjs /tmp/pippit-registry-install/node_modules/.bin/pippit-mcp")
expect(workflow).not.toContain("Refuse an occupied npm version")
expect(workflow).toContain(
"diff -ru local-mcp-existing/package registry-mcp-existing-extracted/package",
)
expect(workflow).toContain("for attempt in 1 2 3 4 5 6")
})

it("uses explicit relative tarball paths for npm 12 publish and install commands", async () => {
const workflow = await readFile(resolve(root, ".github/workflows/plugin-release.yml"), "utf8")

expect(workflow).toContain('local_tarball="./release/pippit-bridge-contracts-${CONTRACTS_VERSION}.tgz"')
expect(workflow).toContain('local_tarball="./release/pippit-bridge-core-${CORE_VERSION}.tgz"')
expect(workflow).toContain('npm publish "./release/pippit-bridge-mcp-server-${{ inputs.version }}.tgz"')
expect(workflow).toContain(
'local_tarball="./release/pippit-bridge-mcp-server-${{ inputs.version }}.tgz"',
)
expect(workflow).toContain(
'npm publish "$local_tarball" --access public --provenance --registry=https://registry.npmjs.org',
)
expect(workflow).toContain(
'npm install --prefix /tmp/pippit-contracts-registry-install --ignore-scripts "./registry-contracts-verify/pippit-bridge-contracts-${CONTRACTS_VERSION}.tgz"',
)
Expand Down