feat(catalog): ignore LeadMagic verification bookkeeping fields - #529
Merged
Merged
Conversation
…chive comparison After the validated_at declaration went live, a batch re-verification showed most re-fetches still differing in two to five fields around the verdict: the credits consumed, the pipeline version, the human-readable message and the validation path code change per request while the email status does not. Declaring them keeps the learner on the answer; the relayed body is untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
leadmagic.people.email.verify: addcredits_consumed,pipeline_version,messageandvalidation_path_codetocache.ignore_pathsnext tovalidated_at.Why
Follow-up to #524 and #527. With only
validated_atdeclared, a batch re-verification still counted most re-fetches as changed: the diffs were confined to two to five bookkeeping fields around an unchanged email status. Per-request bookkeeping, not the answer; the relayed body is untouched.Verification
tests/test_archive.pycatalog and ignore-path tests green (pin list updated).