Skip to content

fix(catalog): drop location_name from DataForSEO Maps live - #558

Merged
stonexer merged 1 commit into
mainfrom
cursor/dataforseo-maps-live-drop-location-name-4e9a
Sep 17, 2026
Merged

stonexer merged 1 commit into
mainfrom
cursor/dataforseo-maps-live-drop-location-name-4e9a

Conversation

@stonexer

@stonexer stonexer commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

What this does

Feedback #516: live /serp/google/maps/live/advanced rejects location_name with task status 40501 Invalid Field: 'location_name', the same class as related-keywords filters (#546 / #439) and order_by (#54). catalog_get listed location_name as an alternative to location_code / location_coordinate, so agents sent it.

  • Remove location_name from dataforseo.x.serp-google-maps-live-advanced request body params
  • Warn in input.note and rewrite the location_code / location_coordinate notes so they no longer treat location_name as an accepted alternative (use location_code or location_coordinate; Live Maps returns 40501)
  • Keep cost, path, capability, the location_code: 2840 example, and sibling News live/advanced (still documents location_name)

Fragment updated: docs/context/architecture/catalog.md. Settlement, routing, and credentials are unchanged.

How it was tested

  • uv run --frozen python -m pytest -q tests/test_dataforseo_constraints.py tests/test_catalog_api.py::test_catalog_get_dataforseo_maps_live_omits_location_name — 23 passed
  • uv run --with pytest-xdist pytest -n auto -q — 4376 passed, 8 skipped
  • CI on this branch is green (test, test-postgres, gitleaks)

Checklist

  • uv run --with pytest-xdist pytest -n auto -q passes locally
  • Added or updated tests for the change (if it affects behavior)
  • Updated the relevant docs/context/ fragment (if a subsystem changed)
  • No secrets in the diff (keys, tokens, .env values)
Open in Web Open in Cursor 

Feedback #516: live /serp/google/maps/live/advanced rejects
location_name with 40501 Invalid Field, same class as related
keywords filters (#439) and order_by (#54). catalog_get listed it
as an alternative to location_code / location_coordinate, so agents
sent it. Remove the field, warn in the input note, leave sibling
News location_name and settlement unchanged.

Co-authored-by: SToneX <shitianxin@gmail.com>
@github-actions github-actions Bot added the area:docs Documentation & design fragments label Sep 17, 2026
@stonexer
stonexer marked this pull request as ready for review September 17, 2026 14:04
@stonexer
stonexer merged commit c536e57 into main Sep 17, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:docs Documentation & design fragments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants