fix(catalog): drop location_name from DataForSEO Maps live - #558
Merged
stonexer merged 1 commit intoSep 17, 2026
Merged
Conversation
Feedback #516: live /serp/google/maps/live/advanced rejects location_name with 40501 Invalid Field, same class as related keywords filters (#439) and order_by (#54). catalog_get listed it as an alternative to location_code / location_coordinate, so agents sent it. Remove the field, warn in the input note, leave sibling News location_name and settlement unchanged. Co-authored-by: SToneX <shitianxin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Feedback #516: live
/serp/google/maps/live/advancedrejectslocation_namewith task status 40501Invalid Field: 'location_name', the same class as related-keywordsfilters(#546 / #439) andorder_by(#54).catalog_getlistedlocation_nameas an alternative tolocation_code/location_coordinate, so agents sent it.location_namefromdataforseo.x.serp-google-maps-live-advancedrequest body paramsinput.noteand rewrite thelocation_code/location_coordinatenotes so they no longer treatlocation_nameas an accepted alternative (uselocation_codeorlocation_coordinate; Live Maps returns 40501)location_code: 2840example, and sibling Newslive/advanced(still documentslocation_name)Fragment updated:
docs/context/architecture/catalog.md. Settlement, routing, and credentials are unchanged.How it was tested
uv run --frozen python -m pytest -q tests/test_dataforseo_constraints.py tests/test_catalog_api.py::test_catalog_get_dataforseo_maps_live_omits_location_name— 23 passeduv run --with pytest-xdist pytest -n auto -q— 4376 passed, 8 skippedtest,test-postgres,gitleaks)Checklist
uv run --with pytest-xdist pytest -n auto -qpasses locallydocs/context/fragment (if a subsystem changed).envvalues)