ci: add UMD smoke test to ci-superdoc pipeline (SD-1917)#2029
ci: add UMD smoke test to ci-superdoc pipeline (SD-1917)#2029caio-pizzol merged 2 commits intomainfrom
Conversation
SD-1917: Loads the locally built UMD bundle in a headless browser after build and asserts window.SuperDocLibrary initializes without errors.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4b12888ddc
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -0,0 +1,16 @@ | |||
| import { test, expect } from '@playwright/test'; | |||
There was a problem hiding this comment.
This file is added under packages/superdoc with a .test.ts suffix, so it is matched by the normal Vitest run (pnpm test in .github/workflows/ci-superdoc.yml runs before the Playwright step, and vitest.config.mjs includes ./packages/superdoc while packages/superdoc/vite.config.js only excludes **/*.spec.js). Because the test uses @playwright/test instead of Vitest’s test, Vitest will try to process it as a unit test file and can fail the pipeline before the dedicated UMD smoke test stage runs.
Useful? React with 👍 / 👎.
The Playwright smoke test was being picked up by vitest's default *.test.ts glob, causing a test() conflict error.
caio-pizzol
deleted the
caio/sd-1917-add-umd-smoke-test-to-ci-pipeline
branch
1 participant
No description provided.