Add new Drives

[MoriGM]

Add missing two Kreon drives and the new two MT1339E drives.

I added the logs for the new two drives.
DH16D5S.log
DH41N.log

Summary by CodeRabbit

• Chores
  • Added support for additional DVD-ROM drive models and their firmware variants.

[coderabbitai]

📝 Walkthrough

Walkthrough

The drive.ixx file's internal DRIVE_DATABASE is extended with four new optical drive model entries: two general PATCHED records for HL-DT-ST and PLDS DVD-ROM models, and two PATCHED KREON records for TSSTcorp models. Each entry includes drive-specific firmware identifiers, vendor metadata, and read configuration parameters.

Changes

Drive Database Configuration

Layer / File(s)	Summary
PATCHED and KREON drive records drive.ixx	Two new PATCHED entries for HL-DT-ST DVD-ROM DH41N and PLDS DVD-ROM DH-16D5S with read offset and sector configuration. Two new PATCHED KREON entries for TSSTcorp DVD-ROM SH-D163A and SH-D162D with firmware identifiers, KREON vendor_specific prefix, and sector_order settings.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• superg/redumper#367: Modifies drive.ixx's DRIVE_DATABASE with vendor_specific-aware lookups and PATCHED database changes using similar fields.
• superg/redumper#299: Updates drive.ixx's DRIVE_DATABASE by extending the PATCHED/recommended drive configuration set.
• superg/redumper#369: Adds new entries to the shared DRIVE_DATABASE for previously unsupported optical drive models.

Poem

🐰 Four new drives join the database queue,
HL-DT-ST, PLDS, and Kreon too!
With firmware codes and sector maps so neat,
The redumper's reach becomes complete. ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'Add new Drives' is vague and generic, using non-descriptive language that doesn't specify which drives were added or their significance to the codebase.	Improve the title to be more specific, such as 'Add support for HL-DT-ST DH41N, PLDS DH-16D5S, and TSSTcorp KREON drives' to clearly communicate the primary change.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@drive.ixx`:
- Line 183: The database entry for the PLDS DVD-ROM DH-16D5S uses a
timestamp-like vendor_specific string which prevents drive_find_in_database from
matching patched drives; update the entry for the record containing "PLDS",
"DVD-ROM DH-16D5S" (the vendor_specific field) to a non-restrictive value (e.g.,
an empty string) so matching is based on the other fields instead of exact
vendor_specific equality.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 76bc7877-c077-4707-b523-4f28f6e63209

📥 Commits

Reviewing files that changed from the base of the PR and between d4fcfe1 and 40a5233.

📒 Files selected for processing (1)

• drive.ixx

[apemax]

Also been testing the DH41N with the ZZ00 firmware.

All the hashes for the discs that I've successfully dumped so far using this drive have matched both previous dumps I've done with other drives (H353C and ASUS BC-12D2HT flashed to Omnidrive) and from redump.

So far from my testing this drive seems to read damaged discs much better compared to the H353C and ASUS BC-12D2HT. I only managed to dump my G Police PC disc with my ASUS BC-12D2HT after setting redumper --speed=1 while the H353C wouldn't even recognise it in the drive. The DH41N on the other hand read the whole disc fine with no C2/SCSI errors without having to lower the speed manually at all.

I have also dumped a couple of other discs that got C2 errors with the H353C but dump fine with the DH41N.

Lead-out wise it seems to get around twice what the H353C can get:

warning: lead-out contains non-zero data (session: 1, sectors: 12408/12410)

The only strange thing I noticed was with a specific PS1 game disc, Hot Wheels Turbo Racing. I got the below SCSI error right at the beginning of the disc.

[LBA: 14] SCSI error (SC: CHECK CONDITION, SK: MEDIUM ERROR, ASC: UNRECOVERED READ ERROR)

This only seems to happen with this drive as I have dumped this disc with my H353C and I didn't get this error with that drive. So far that's the only disc I've got that error with though so could be something specific to my specific disc and drive. Full log below:

Hot_Wheels_Turbo_Racing.log

Drive test log and several dump logs attached below:

DH41N_Drive_Test_ZZ00.txt
G_Police_PC.log
OPSM_Demo_Disc_68.log
OPSM_Demo_Disc_82.log
DPCSRENSB1.log

[superg]

@apemax thanks for testing, if other PSX discs are ok I think it might be a combination of particular disc that drive doesn't like.

[superg]

Thanks for more drives, merging!