Redump dot info

[superg]

Summary by CodeRabbit

• New Features

  • Added logging macro for enhanced console output handling

• Refactor

  • Updated internal method signatures across disc system modules for consistency
  • Refined logging output formatting in dump and verification operations
  • Enhanced error information display to consistently show detailed location references

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e11ff8fc-7165-4905-8d8a-8a1d125002e1

📥 Commits

Reviewing files that changed from the base of the PR and between 6213d3c and 763e28b.

📒 Files selected for processing (23)

• cd/cd_dump.ixx
• cd/cd_dump_extra.ixx
• drive/test.ixx
• dvd/dvd_dump.ixx
• info.ixx
• systems/dc.ixx
• systems/gc.ixx
• systems/mcd.ixx
• systems/ps2.ixx
• systems/ps3.ixx
• systems/ps4.ixx
• systems/ps5.ixx
• systems/psx.ixx
• systems/s_cdrom.ixx
• systems/s_hfs.ixx
• systems/s_high_sierra.ixx
• systems/s_iso.ixx
• systems/s_xbox.ixx
• systems/sat.ixx
• systems/securom.ixx
• systems/system.hh
• systems/wii.ixx
• utils/logger.ixx

---

📝 Walkthrough

Walkthrough

Adds a new LOGC_R console-only logging macro and migrates LOG/LOG_R call sites across CD dump, DVD dump, and drive test code to use LOGC/LOGC_R. Separately removes the bool verbose parameter from System::printInfo's pure-virtual interface, propagates the signature change to all 15+ system overrides and the info.ixx call site, and updates SystemCDROM to always print LBA details with a REDUMP.INFO label.

Changes

Console-only Logging Macro Adoption

Layer / File(s)	Summary
New LOGC_R macro definition utils/logger.ixx	Exports LOGC_R as a new template function: emits a carriage return, formats the message to console only, and terminates with lineFeed(false).
CD dump logging macro updates cd/cd_dump.ixx, cd/cd_dump_extra.ixx	Switches subcode desync, SCSI read error, C2 bit-count, correction success, and correction failure calls from LOG_R to LOGC_R in cd_dump.ixx; updates lead-out SCSI error and C2 reporting in cd_dump_extra.ixx.
DVD dump logging macro updates dvd/dvd_dump.ixx	Switches correction success, Kreon lock confirmation, SCSI read error, EDC mismatch, and correction failure calls from LOG_R to LOGC_R.
Drive test logging macro updates drive/test.ixx	Replaces LOG with LOGC for all verbose SCSI error and subcode warning paths across cmd_read_cd, cmd_read_cd_msf, cmd_read_cd_msf_d5, cmd_read_cdda, Plextor pregap/lead-out loops, and the MediaTek cache read failure branch.

Remove bool verbose from printInfo Interface

Layer / File(s)	Summary
Base class interface and call site systems/system.hh, info.ixx	Removes bool verbose from System::printInfo's pure-virtual signature and drops options.verbose from the system->printInfo invocation.
SystemCDROM behavioral output change systems/s_cdrom.ixx	Drops the verbose parameter and unconditionally emits LBA range details for every diagnostic category; renames the summary label from REDUMP.ORG errors to REDUMP.INFO errors with adjusted newline formatting.
All other system printInfo override signatures systems/dc.ixx, systems/gc.ixx, systems/mcd.ixx, systems/ps2.ixx, systems/ps3.ixx, systems/ps4.ixx, systems/ps5.ixx, systems/psx.ixx, systems/sat.ixx, systems/securom.ixx, systems/s_hfs.ixx, systems/s_high_sierra.ixx, systems/s_iso.ixx, systems/s_xbox.ixx, systems/wii.ixx	Removes the trailing bool parameter from the printInfo override in each system class; SystemPS3 additionally corrects its path argument from a non-const to a const & reference.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• superg/redumper#268: Directly modifies the printInfo interface and call path including the verbosity flag in info.ixx, systems/system.hh, and the system overrides — the same interface this PR is cleaning up.
• superg/redumper#386: Adds the SystemHFS::printInfo implementation whose signature this PR updates to remove the trailing bool.
• superg/redumper#363: Refactors redumper_dump_cd error and progress handling in cd/cd_dump.ixx at the same SCSI/C2/correction log points that this PR switches from LOG_R to LOGC_R.

Poem

🐇 Hop hop, the logs now console-bound,
No bool verbose to pass around!
LOGC_R leaps with carriage flair,
Erasing lines with bunny care.
Fifteen overrides, all inline —
The printInfo trail is now so fine! 🌿

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'Redump dot info' is vague and does not clearly convey the main changes in the pull request, which involve removing a verbose parameter from printInfo signatures across multiple system implementations and updating logging macros.	Consider a more descriptive title such as 'Remove verbose parameter from printInfo method signatures' or 'Update printInfo interface and logging macros' to better reflect the substantive changes made.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch redump_dot_info

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}