Skip to content

feat: add .editorconfig and .gitattributes for consistent file formatting#328

Open
ChuckieChen945 wants to merge 1 commit intosuperlinear-ai:mainfrom
ChuckieChen945:feature
Open

feat: add .editorconfig and .gitattributes for consistent file formatting#328
ChuckieChen945 wants to merge 1 commit intosuperlinear-ai:mainfrom
ChuckieChen945:feature

Conversation

@ChuckieChen945
Copy link
Copy Markdown

close #327

@davebulaval
Copy link
Copy Markdown

Thanks for the contribution @ChuckieChen945! 🙏

We identified a few issues with this PR:

  1. Wrong directory: Files are placed in template/ but our cookiecutter template directory is {{ cookiecutter.__project_name_kebab_case }}/
  2. .editorconfig already exists: The template already has one — this would create a duplicate in the wrong location
  3. max_line_length: Set to 88 but our Baseline convention uses 99

We've incorporated the good parts of your contribution (especially .gitattributes) with the necessary fixes in #28.

Thanks again for the idea — the .gitattributes addition is a great improvement!

@ChuckieChen945
Copy link
Copy Markdown
Author

We've incorporated the good parts of your contribution (especially .gitattributes) with the necessary fixes in #28.

In addition, this PR has been absorbed by Baseline-quebec/baseline-app-cookiecutter here:
Baseline-quebec#28 , not #28

@lsorber
Copy link
Copy Markdown
Member

lsorber commented Mar 23, 2026

What problem(s) does this PR address, for my information?

@ChuckieChen945
Copy link
Copy Markdown
Author

This PR introduces project-wide standards for code formatting and line endings to address the following:

  • Cross-Platform Consistency: Prevents "hidden" diffs caused by different operating systems (Windows vs. Unix) using different line endings (CRLF vs. LF).
  • Enforced Normalization: Using .gitattributes ensures Git handles line endings consistently for everyone, regardless of their local core.autocrlf settings.
  • Editor Synchronization: .editorconfig automatically configures contributors' IDEs (indentation, charset, trailing spaces), reducing manual formatting overhead and keeping the codebase clean.

In short, it minimizes "noise" in PRs and ensures the code looks and behaves the same for every developer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature request]Add .editorconfig and .gitattributes for workspace consistency

3 participants