Skip to content

Target Porter application nodes by default - #2

Merged
arseniycodes merged 1 commit into
mainfrom
ash/porter-safe-scheduling
Jul 21, 2026
Merged

arseniycodes merged 1 commit into
mainfrom
ash/porter-safe-scheduling

Conversation

@arseniycodes

@arseniycodes arseniycodes commented Jul 20, 2026 •

Copy link
Copy Markdown
Member

Summary

  • schedule the node collector only on Porter Application nodes by default
  • keep Kubernetes events and workload-state collection cluster-wide
  • support an explicit all-node override through Helm values
  • document coexistence with Porter built-in monitoring and the pod-capacity tradeoff
  • release chart version 0.1.1

Testing

  • bash scripts/validate.sh
  • shellcheck scripts/*.sh charts/superlog-otel/tests/*.sh
  • actionlint
  • git diff --check

Summary by cubic

Default the superlog-otel node agent to run only on Porter Application nodes to avoid pod pressure on System nodes, while keeping cluster-wide events and workload metrics. Adds an all-nodes opt-in via Helm values and bumps the chart to 0.1.1.

  • New Features
    • DaemonSet now uses node affinity on porter.run/workload-kind: application by default.
    • New value collectors.agent.porterNodeGroups (default ["application"]); set to [] to target all Linux nodes.
    • Updated docs on Porter node groups, scheduling tradeoffs, and coexistence with built-in monitoring.
    • Tests updated to assert defaults, override behavior, and chart version.

Written for commit 6ce0eb6. Summary will update on new commits.

Review in cubic

@arseniycodes

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: 6ce0eb65ac

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@arseniycodes
arseniycodes merged commit dcdf727 into main Jul 21, 2026
2 checks passed
@arseniycodes
arseniycodes deleted the ash/porter-safe-scheduling branch July 21, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant