Repository navigation
Add synchronous span helper - #1
superlog-responder[bot] wants to merge 2 commits into
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 914a111df4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
arseniycodes
left a comment
arseniycodes
left a comment
There was a problem hiding this comment.
Codex's two comments on src/span.ts (comments 4207378835 and 4207378862) are still open. Please address them and reply on each.
1 participant
Summary
withSyncSpanhelper alongsidewithSpanVerification
npm run typechecknpx vitest run --pool=threads --poolOptions.threads.singleThread=truenpm run buildSummary by cubic
Adds a
withSyncSpanhelper that wraps synchronous callbacks in spans, matching the existing asyncwithSpanbehavior. The helper is exported from the package entrypoint, records errors on thrown callbacks, and throws aTypeErrorif the callback returns a Promise to steer callers towardwithSpan. Covered by tests for callback execution, options, return values, error recording, and span completion.Written for commit 440a992. Summary will update on new commits.