Repository navigation
Keep the onboarding stepper on screen between setup steps - #348
Merged
Merged
Conversation
Creating a workspace no longer reloads the page or passes through the workspace list and the generic loading card. The gate keeps workspace setup mounted until it has opened the next step in place. Loading states on /onboarding URLs, including after a page load such as the return from checkout, use the setup card with the stepper.
The Usage and Go live steps are full width, so a loading card with the explainer changed shape when the step appeared.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
During guided setup the stepper card disappeared and came back several times.
After Create workspace, the screen went: stepper → "Choose a workspace" card (the new workspace joined the list) → "Loading Superlog…" → a full page reload → "Loading Superlog…" → stepper. Any page load on a step, such as the return from plan checkout or the Datadog connection, also showed the plain "Loading Superlog…" card before the stepper.
Change
AuthGatekeepsWorkspaceSetupmounted while it creates a workspace. Setup then navigates in place to the next page (/onboarding/code,/agents/new, or the template being set up) instead of callingwindow.location.replace.WorkspaceSetupstays in guided mode once shown, so the list refetch after creation does not switch it to the workspace chooser.OnboardingLoadingcard (the setup frame with the stepper and "Loading…"). It is used for the session and capabilities loading states on/onboardingURLs, and for the onboarding page's own loading state.onboardingStepAtPathreads the step from a setup URL, with tests.onboardingStepStages). The Usage and Go live steps are full width, so the card no longer changes shape when they appear.Verification
Recorded DOM transitions with Playwright against the local stack (sign up → create workspace → steps → reload):
Before:
After:
A reload on
/onboarding/usagenow goes from a blank document straight to the stepper loading card.pnpm typecheck, eslint on changed files, and theauth-gateandonboarding-presentationunit tests pass.e2e/workspace-onboarding.spec.ts: 5 passed, including both workspace-creation tests.keeps an invitation link open while the recipient signs infails because it looks for a "New to Responder? Create an account" button that is not inmain's source. That failure is unrelated to this change.Summary by cubic
Keeps the guided setup stepper on screen between steps. Creating a workspace no longer drops into the workspace chooser and a plain "Loading Superlog…" card before reloading; the auth gate keeps setup mounted and navigates in place to the next step.
/onboardingURLs use the stepper card with "Loading…" instead of the plain loading card.Written for commit de9a295. Summary will update on new commits.