Repository navigation
Block sign-ups from configured email domains - #532
Open
arseniycodes wants to merge 1 commit into
Open
arseniycodes wants to merge 1 commit into
arseniycodes wants to merge 1 commit into
Conversation
Adds SIGNUP_BLOCKED_EMAIL_DOMAINS, a comma-separated list of email domains (and their subdomains) that may not create accounts. Enforced in Better Auth's user.create.before hook, so it covers email/password, social, and admin-created users alike. Blocked attempts get a 403 and no user row is written. Unset = nothing blocked. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SIGNUP_BLOCKED_EMAIL_DOMAINSenv var on the api: a comma-separated list of email domains that may not create accounts. Subdomains of a listed domain are blocked too; matching is case-insensitive and uses the domain after the last@.databaseHooks.user.create.before, so it applies to email/password, Google/GitHub, and admin-created users. A blocked attempt returns403 {"message":"Sign-ups from this email domain are not allowed."}and writes no user row.Useful for shutting off a domain that's sending spam sign-ups without a code change.
Testing
signup-email-domains.test.ts: parsing, case-insensitivity, subdomains, lookalike domains (notspam.example,spam.example.org), and quoted local parts.POST /api/auth/sign-up/emailwith a blocked domain → 403 and no user stored; an allowed domain → 200.pnpm --filter @superlog/api typecheckpasses.🤖 Generated with Claude Code
Summary by cubic
Adds a
SIGNUP_BLOCKED_EMAIL_DOMAINSenv var that blocks account creation from listed email domains, so a domain sending spam sign-ups can be shut off without redeploying.New Features
@.Written for commit a57e6ba. Summary will update on new commits.