Skip to content

Validate special ping packets before decoding #5818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alayan-stk-2 merged 1 commit into from
Sep 16, 2026
+15 −0
Merged

Validate special ping packets before decoding #5818

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/network/stk_host.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1127,12 +1127,27 @@ void STKHost::mainLoop(ProcessType pt)
{
if (!is_server)
{
const size_t header_size = g_ping_packet.size() +
sizeof(uint64_t) + sizeof(uint8_t);
if (event.packet->dataLength < header_size)
{
Log::warn("STKHost", "Invalid ping packet size.");
enet_packet_destroy(event.packet);
continue;
}
BareNetworkString ping_packet((char*)event.packet->data,
(int)event.packet->dataLength);
std::map<uint32_t, uint32_t> peer_pings;
ping_packet.skip((int)g_ping_packet.size());
uint64_t server_time = ping_packet.getUInt64();
unsigned peer_size = ping_packet.getUInt8();
if (ping_packet.size() < peer_size *
(sizeof(uint32_t) * 2))
{
Log::warn("STKHost", "Invalid ping peer list.");
enet_packet_destroy(event.packet);
continue;
}
for (unsigned i = 0; i < peer_size; i++)
{
unsigned host_id = ping_packet.getUInt32();
Expand Down