Repository navigation
Conversation
acts-1631
force-pushed
the
fix-connection-request-length
branch
from
September 28, 2026 16:39
0429d83 to
35e7e25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ServerLobby::connectionRequestedhandles the first lobby packet before a peer is validated. It readsencrypted_sizeand passesdata.getCurrentData()plus that attacker-controlled length toBareNetworkString, whose constructor callsmemcpywithout checking how many bytes remain.A crafted connection request can make the server read past the ENet packet buffer during admission. Short bodies can also reach the crypto path with less data than the AES-GCM tag requires.
This change checks the selected tag size and requires
encrypted_sizeto fit within the unread packet before copying. Invalid requests are logged and disconnected.