Skip to content

Ignore client race-finished notifications on server #5881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alayan-stk-2 merged 2 commits into from
Sep 22, 2026
Merged

Ignore client race-finished notifications on server #5881

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bab841b
Reject client race-finished notifications
acts-1631 Sep 16, 2026
1bc2e65
Restrict game events accepted from clients
acts-1631 Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/network/protocols/game_events_protocol.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,15 @@ bool GameEventsProtocol::notifyEvent(Event* event)
return true;
}
uint8_t type = data.getUInt8();
// Only startup boost is sent from a client. All other game events are
// notifications sent by the server.
if (NetworkConfig::get()->isServer() && type != GE_STARTUP_BOOST)
{
Log::warn("GameEventsProtocol",
"Ignoring client game event %d from %s.", type,
event->getPeer()->getAddress().toString().c_str());
return true;
}
CaptureTheFlag* ctf = dynamic_cast<CaptureTheFlag*>(World::getWorld());
FreeForAll* ffa = dynamic_cast<FreeForAll*>(World::getWorld());
SoccerWorld* sw = dynamic_cast<SoccerWorld*>(World::getWorld());
Expand Down Expand Up @@ -105,6 +114,12 @@ bool GameEventsProtocol::notifyEvent(Event* event)
{
if (NetworkConfig::get()->isServer())
{
if (data.size() < 1)
{
Log::warn("GameEventsProtocol",
"Too short startup boost request.");
return true;
}
uint8_t kart_id = data.getUInt8();
if (!event->getPeer()->availableKartID(kart_id))
{
Expand Down