Skip to content

Update the AngelScript lib to 2.38.0 (last stable version) - #5900

Merged
Alayan-stk-2 merged 13 commits into
supertuxkart:masterfrom
SewerFox:update-angelscript
Oct 13, 2026
Merged

Alayan-stk-2 merged 13 commits into
supertuxkart:masterfrom
SewerFox:update-angelscript

Conversation

@SewerFox

@SewerFox SewerFox commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

The bundled in-game version was updated in 2021, so it's very outdated

Note: Later, will be launched the 2.39.0 version fyi

Targets #5894 btw

Agreement

By creating a pull request in stk-code, you hereby agree to dual-license your contribution as
GNU General Public License version 3 or any later version and
Mozilla Public License version 2 or any later version.

This includes your previous contribution(s) under the same name of contributor.

You also confirm that this contribution is your own original work
and that it does not contain code generated by AI tools.

Keep the above statement in the pull request comment for agreement.

@Alayan-stk-2

Copy link
Copy Markdown
Member

2 big issues so far:

  • CI fails on Windows and Apple
  • The diff is gigantic. If you check the actual files, most of the code is completely identical across both versions. This is likely due to windows-line endings (\r\n) vs UNIX line endings (\n). For the diff to not be complete noise, the line endings format should be unchanged in the update.

@SewerFox

Copy link
Copy Markdown
Contributor Author
* The diff is gigantic. If you check the actual files, most of the code is completely identical across both versions. This is likely due to windows-line endings (\r\n) vs UNIX line endings (\n). For the diff to not be complete noise, the line endings format should be unchanged in the update.

How I do this?

@Alayan-stk-2

Copy link
Copy Markdown
Member

How I do this?

Use dos2unix or unix2dos on the files within the angelscript folder (you should be able to batch the changes rather than having to do it per-file). See https://en.wikipedia.org/wiki/Unix2dos

Check whichever direction change reduces the diff to a reasonable size.

@SewerFox

Copy link
Copy Markdown
Contributor Author

Windows CI build fixed

I used dos2unix to convert all the files to Unix-type
@SewerFox

Copy link
Copy Markdown
Contributor Author

How I do this?

Use dos2unix or unix2dos on the files within the angelscript folder (you should be able to batch the changes rather than having to do it per-file). See https://en.wikipedia.org/wiki/Unix2dos

Check whichever direction change reduces the diff to a reasonable size.

Fixed

@SewerFox

Copy link
Copy Markdown
Contributor Author

Apple CI build was fixed.

Ready for review again :)

@Alayan-stk-2

Copy link
Copy Markdown
Member

STK had a few specific patches to AngelScript over the years. Essentially compatibility things.

https://github.com/supertuxkart/stk-code/commits/master/lib/angelscript

Some appear to still be in the codebase (or have also been merged upstream), like the DragonFly or Haiku patch, most appear to be just quick fixes to get it to compile but there are some patches that have been effectively reverted without it being obvious if they would still serve a purpose. Namely:
bee1c22 and 184c801

@SewerFox

Copy link
Copy Markdown
Contributor Author

That's small things.

And about the first mod, I put smth like it

@Alayan-stk-2

Copy link
Copy Markdown
Member

Well, I guess if there is an issue, we'll notice at some point.

@Alayan-stk-2
Alayan-stk-2 merged commit b068931 into supertuxkart:master Oct 13, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants