Fix administrator setup validation and recovery UX#169
Open
support371 wants to merge 6 commits into
Open
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 34768571 | Triggered | JSON Web Token | d9e8ceb | src/lib/admin-access-validation.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Reviewer's GuideImplements server-side and client-side validation of the one-time administrator setup capability before allowing password creation, adds UX for missing/invalid/expired authorization, and wires this through a new Supabase-backed validation RPC and API route with tests and a migration. Sequence diagram for admin access token validation before password setupsequenceDiagram
actor Owner
participant AdminAccessAuthorizePage as AdminAccessAuthorizePage
participant AdminAccessPage as AdminAccessPage
participant ApiValidate as Api_admin-access-validate_POST
participant SupabaseRPC as Supabase_gem_validate_admin_access_token
Owner->>AdminAccessAuthorizePage: generateAdminAccessAuthorization()
AdminAccessAuthorizePage->>Owner: Show SQL and token
Owner->>SupabaseRPC: Run SQL in Supabase
Owner->>AdminAccessAuthorizePage: click verifyAndContinue()
AdminAccessAuthorizePage->>ApiValidate: POST /api/admin-access/validate {accessToken}
ApiValidate->>SupabaseRPC: POST /rest/v1/rpc/gem_validate_admin_access_token {p_token_hash}
SupabaseRPC-->>ApiValidate: {valid, expires_at, request_id}
ApiValidate-->>AdminAccessAuthorizePage: {valid, expiresAt, requestId}
AdminAccessAuthorizePage->>AdminAccessPage: window.location.assign(/admin-access#token=...)
AdminAccessPage->>ApiValidate: POST /api/admin-access/validate {accessToken}
ApiValidate->>SupabaseRPC: POST gem_validate_admin_access_token {p_token_hash}
SupabaseRPC-->>ApiValidate: {valid}
ApiValidate-->>AdminAccessPage: {valid}
AdminAccessPage->>AdminAccessPage: tokenState = valid
AdminAccessPage->>AdminAccessPage: submit() allowed only when tokenState === valid
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 1 security issue, and left some high level feedback:
Security issues:
- Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data. (link)
General comments:
- The hardcoded DEFAULT_SUPABASE_URL and DEFAULT_SUPABASE_ANON_KEY in
admin-access-validation.tseffectively bake environment-specific credentials into the codebase; consider moving these to environment variables with safer defaults and using explicit test-only values in the unit tests instead. - The PL/pgSQL function
gem_validate_admin_access_tokenhardcodes the administrator email and role/status constraints; if you ever need to support different admin identities or environments, consider parameterizing or centralizing these checks rather than duplicating them in the function. - In the new
/api/admin-access/validateroute, the generic 400 error message "Invalid authorization capability." may make debugging harder when schema validation fails; consider returning more specific feedback based on Zod’s parse errors while still avoiding leakage of sensitive details.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The hardcoded DEFAULT_SUPABASE_URL and DEFAULT_SUPABASE_ANON_KEY in `admin-access-validation.ts` effectively bake environment-specific credentials into the codebase; consider moving these to environment variables with safer defaults and using explicit test-only values in the unit tests instead.
- The PL/pgSQL function `gem_validate_admin_access_token` hardcodes the administrator email and role/status constraints; if you ever need to support different admin identities or environments, consider parameterizing or centralizing these checks rather than duplicating them in the function.
- In the new `/api/admin-access/validate` route, the generic 400 error message "Invalid authorization capability." may make debugging harder when schema validation fails; consider returning more specific feedback based on Zod’s parse errors while still avoiding leakage of sensitive details.
## Individual Comments
### Comment 1
<location path="src/lib/admin-access-validation.ts" line_range="3" />
<code_context>
eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJzdXBhYmFzZSIsInJlZiI6InNsemRqb3FwemJrd3p1YWV4bGtqIiwicm9sZSI6ImFub24iLCJpYXQiOjE3ODMyOTk1MTQsImV4cCI6MjA5ODg3NTUxNH0.0wfgX_m6SBn_TtD0ZNjkOZ-bk8Frp2Tq1HL9mYFBm4M
</code_context>
<issue_to_address>
**security (jwt):** Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
*Source: betterleaks*
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| @@ -0,0 +1,70 @@ | |||
| const DEFAULT_SUPABASE_URL = "https://slzdjoqpzbkwzuaexlkj.supabase.co"; | |||
| const DEFAULT_SUPABASE_ANON_KEY = | |||
| "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJzdXBhYmFzZSIsInJlZiI6InNsemRqb3FwemJrd3p1YWV4bGtqIiwicm9sZSI6ImFub24iLCJpYXQiOjE3ODMyOTk1MTQsImV4cCI6MjA5ODg3NTUxNH0.0wfgX_m6SBn_TtD0ZNjkOZ-bk8Frp2Tq1HL9mYFBm4M"; | |||
There was a problem hiding this comment.
security (jwt): Uncovered a JSON Web Token, which may lead to unauthorized access to web applications and sensitive user data.
Source: betterleaks
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
gem-enterprise | 40229ae | Jul 13 2026, 03:44 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The live administrator password form accepted submissions but
/api/admin-accessreturned 400 because the matching one-time authorization row was absent or expired. The page also attempted/api/admin-access/validate, which was not deployed onmain, causing a 404 and leaving the user without an actionable diagnosis.Fix
/api/admin-access/validate.Safety
Summary by Sourcery
Add server-side token validation and improved UX for administrator password setup to ensure only active, registered browser capabilities can reach the password screen.
New Features:
Enhancements:
Deployment:
gem_validate_admin_access_tokenfunction for validating admin access tokens using hashed values.Tests: